Build and publish multi-arch docker images on tag #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vreynolds
reviewed
Sep 28, 2021
vreynolds
approved these changes
Sep 29, 2021
robbkidd
reviewed
Sep 30, 2021
There was a problem hiding this comment.
Carrying over some @ismith's recommendations in similar changes to honeymarker
Co-authored-by: Robb Kidd <robbkidd@honeycomb.io>
…i-arch-docker * 'main' of github.com:honeycombio/refinery: Add dynamic sampler support to rules based samplers (#317)
robbkidd
reviewed
Oct 1, 2021
robbkidd
reviewed
Oct 1, 2021
ghost
pushed a commit
to opsramp/tracing-proxy
that referenced
this pull request
Jul 5, 2024
* remove now-unused docker orb
* update Go to 1.16
+ go.mod to 1.16
+ Circle cimg/go to 1.16
* new docker image build script
+ set BuildID ldflags
+ use ko to perform the multi-arch image build *and* publish
* new docker_publish job
+ runs the new image build script
+ setup_remote_docker so a docker service is available during the job
+ caches the ko installation
+ runs on all build workflow executions
- if running on a tag, publishes to Docker Hub
- all other builds, publishes to local docker registry
Co-authored-by: Robb Kidd <robbkidd@honeycomb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
When publishing to docker, our images should be built and be runnable on multiple architectures. This PR updates our docker image build process to use Google KO to build the image.
Short description of the changes
publish_dockerjob