Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update rules example #378

Merged
merged 2 commits into from
Jan 18, 2022
Merged

docs: update rules example #378

merged 2 commits into from
Jan 18, 2022

Conversation

vreynolds
Copy link
Contributor

rule conditions are ANDed not ORed

Which problem is this PR solving?

  • rule example is confusing because it implies that conditions are ORed

Short description of the changes

  • clarify with a better rule name

@vreynolds
docs: update rules example
7ecf861 
rule conditions are ANDed not ORed
@vreynolds vreynolds requested a review from a team January 14, 2022 22:12
@vreynolds vreynolds added type: documentation version: no bump A PR with maintenance or doc changes that aren't included in a release. labels Jan 14, 2022
@vreynolds vreynolds merged commit 423f235 into main Jan 18, 2022
@vreynolds vreynolds deleted the vreynolds-patch-1 branch January 18, 2022 19:05
ghost pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
@vreynolds
docs: update rules example (honeycombio#378)
bafc1e2 
- rule conditions are ANDed not ORed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees
No one assigned
Labels
type: documentation version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vreynolds @MikeGoldsmith