Skip to content

Commit

Permalink
docs: update rules example (honeycombio#378)
Browse files Browse the repository at this point in the history
- rule conditions are ANDed not ORed
  • Loading branch information
vreynolds authored Jan 18, 2022
1 parent f36c7e2 commit bafc1e2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion config/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ func TestReadRulesConfig(t *testing.T) {

rule = r.Rule[1]
assert.Equal(t, 1, rule.SampleRate)
assert.Equal(t, "500 errors or slow", rule.Name)
assert.Equal(t, "keep slow 500 errors", rule.Name)
assert.Len(t, rule.Condition, 2)

default:
Expand Down
4 changes: 2 additions & 2 deletions rules_complete.toml
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ SampleRate = 1
value = "/health-check"

[[dataset4.rule]]
name = "500 errors or slow"
name = "keep slow 500 errors"
SampleRate = 1
[[dataset4.rule.condition]]
field = "status_code"
Expand All @@ -228,7 +228,7 @@ SampleRate = 1
value = 1000.789

[[dataset4.rule]]
name = "dynamic sample 200 responses"
name = "dynamically sample 200 responses"
[[dataset4.rule.condition]]
field = "status_code"
operator = "="
Expand Down

0 comments on commit bafc1e2

Please sign in to comment.