fix: Fix flaky tests, clean up logic on rules #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentquirk
added
type: bug
kentquirk
changed the title
TylerHelmuth
approved these changes
Jan 31, 2023
| @@ -1392,12 +1403,13 @@ func TestRulesDatatypes(t *testing.T) { | |||
| { | |||
| Event: types.Event{ | |||
| Data: map[string]interface{}{ | |||
| "test": 9.3, | |||
| "test": 9.3, // "9.3" is greater than "10.3" when compared as a string | |||
There was a problem hiding this comment.
Huh. Turns out it's consistent with F# too, so this isn't just some "rob pike is a weird dude" behavior:
λ ~/scratch/otel-pixie/ dotnet fsi
Microsoft (R) F# Interactive version 12.4.0.0 for F# 7.0
Copyright (c) Microsoft Corporation. All Rights Reserved.
For help type #help;;
> "9.3" > "10.3";;
val it: bool = true
There was a problem hiding this comment.
Yeah, alphabetically '9' is greater than '1'. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
tryConvertToStringto just use sprintf("%v"), even for strings, for consistency