feat: Add configuration for trace and parent ID field names #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdarwin
changed the title
kentquirk
requested changes
Mar 6, 2023
There was a problem hiding this comment.
This is close! A few changes, please. Although I originally specified spanID, I think we should leave it off for now since it's unused; we can always add it later.
I had also thought about putting these configurations down a level under a parent key, but decided that too should wait for the config revamp. It's fine the way it is.
…n IDs and parent span Ids Signed-off-by: Davin Taddeo <davin@honeycomb.io>
Signed-off-by: Davin Taddeo <davin@honeycomb.io>
Signed-off-by: Davin Taddeo <davin@honeycomb.io>
Signed-off-by: Davin Taddeo <davin@honeycomb.io>
tdarwin
force-pushed
the
configure_event_ids
branch
from
39bdf23 to
a59f38c
Compare
kentquirk
approved these changes
Mar 10, 2023
kentquirk
changed the title
|
🎉 Thank you all! This is useful to us |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
#626 - Make trace fields configurable
Short description of the changes
This should make trace, span, and parent ID fields configurable, which will allow refinery to work where a client uses a non-standard trace ID field name.
Fixes #626.