Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Rename for clarity in an E&S world #680

Merged
merged 23 commits into from
May 17, 2023
Merged

refactor: Rename for clarity in an E&S world #680

merged 23 commits into from
May 17, 2023

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

  • After Honeycomb introduced environments, the rules file uses environments to specify samplers but still refers to things in code, tests, and documentation as datasets. This fixes the code part -- forthcoming v2 changes will fix the tests and documentation.

Short description of the changes

  • Rename GetSamplerConfigForDataset to GetSamplerConfigForDestName and change its internals as well.
  • ReloadInto was exported because it's needed for the converter

This PR depends on #677 and should be merged after that one.

@kentquirk kentquirk marked this pull request as ready for review May 14, 2023 23:14
@kentquirk kentquirk requested a review from a team as a code owner May 14, 2023 23:14
@kentquirk kentquirk changed the title Rename for clarity in an E&S world refactor: Rename for clarity in an E&S world May 14, 2023
@kentquirk kentquirk added type: maintenance The necessary chores to keep the dust off. status: review needed Changes need review. labels May 14, 2023
@kentquirk kentquirk added this to the v2.0 milestone May 14, 2023
@kentquirk kentquirk mentioned this pull request May 15, 2023
Merged
Base automatically changed from kent.v2.convert_and_validate to main May 15, 2023 21:11
@kentquirk kentquirk requested a review from TylerHelmuth May 15, 2023 22:13
@kentquirk kentquirk merged commit 0a7c00e into main May 17, 2023
@kentquirk kentquirk deleted the kent.v2.rename_dataset_to_destname branch May 17, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

Assignees
No one assigned
Labels
status: review needed Changes need review. type: maintenance The necessary chores to keep the dust off.
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kentquirk @TylerHelmuth