This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
Including amenities and places to hashtag endpoint #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -427,7 +427,8 @@ def test_organization_hashtag_weekly_query(): | |||
| where name = 'msf' | |||
| ), | |||
| t2 as ( | |||
| select name as hashtag, type as frequency , start_date , end_date , total_new_buildings , total_uq_contributors as total_unique_contributors , total_new_road_m as total_new_road_meters | |||
There was a problem hiding this comment.
Update will be needed on Assertion Step ! Replacement of existing query with updated query that will be generated from query builder
| @@ -455,7 +456,8 @@ def test_organization_hashtag_monthly_query(): | |||
| where name = 'msf' | |||
| ), | |||
| t2 as ( | |||
| select name as hashtag, type as frequency , start_date , end_date , total_new_buildings , total_uq_contributors as total_unique_contributors , total_new_road_m as total_new_road_meters | |||
| select name as hashtag, type as frequency , start_date , end_date , total_new_buildings , total_uq_contributors as total_unique_contributors , total_new_road_m as total_new_road_meters, | |||
|
@itskshitiz321 - please check now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the base model, query builder and test function to include new amenities and places statistics.
cc @itskshitiz321