Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

Improve Data Quality : Username Endpoint #229

Merged
merged 11 commits into from
Jun 1, 2022

Conversation

kshitijrajsharma
Copy link
Member

@kshitijrajsharma kshitijrajsharma commented May 31, 2022

Testing API Params :
{"fromTimestamp":"2022-04-25T18:15:00.994Z","toTimestamp":"2022-04-30T18:14:59.994Z","osmUsernames":["Riyadi IRM-ED"],"issueTypes":["all"],"hashtags":["Indonesia"],"outputType":"geojson"}

Should return data quality issues with hashtags missingmaps within that time range inside that username

**This sample is taken by making sure we have data for that user on underpass so it should return result

@kshitijrajsharma kshitijrajsharma marked this pull request as ready for review May 31, 2022 11:07
@d-rita
Copy link
Contributor

d-rita commented Jun 1, 2022

@itskshitiz321 does including the hashtag make it an intersection of results?
I tested with: { "fromTimestamp": "2021-07-01T00:30:00.000", "toTimestamp": "2021-07-30T00:15:00.000", "osmUsernames": [ "Fadlilaa IRM-ED","Bert Araali" ], "issueTypes": [ "all" ], "outputType": "geojson", "hashtags":[] }.
Without a hashtag input, I get results. When I add a hashtag, e.g missing maps, there is none. (it's entirely possible they did not use this hashtag but that is why I wanted to know if we combine the search to get only the intersecting results, and if there are none, it shows zero like in this case).
If so, would we consider showing the available results even if they don't fit the hashtag?
cc: @ramyaragupathy

@kshitijrajsharma
Copy link
Member Author

@d-rita Yeah hashtags will work as intersection just like how mapathon will work

Copy link
Contributor

@d-rita d-rita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected. Good work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants