Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Create Parking workflow to show clear error message while creating parking with duplicate facility ID. #185

Closed
3 tasks
ravilodhi opened this issue Jan 29, 2024 · 2 comments
Closed
3 tasks

Improve Create Parking workflow to show clear error message while creating parking with duplicate facility ID. #185

ravilodhi opened this issue Jan 29, 2024 · 2 comments
Assignees
@Adameddy26
Labels
enhancement New feature or request release-v1.9.0

Comments

@ravilodhi
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

Currently, if we create a parking facility with a duplicate internal ID (facility ID), we receive an error toast with the message 'Failed to create parking.' It would be great if the user could see the exact reason, such as 'Facility with ID already exists.'

Additionally, automatically generate an internal ID if the user removes it manually from the Create Parking form.

What are the acceptance criteria?

  • ...

Can you complete this feature request by yourself?

  • YES
  • NO

Additional information
@ravilodhi ravilodhi added the enhancement New feature or request label Jan 29, 2024
@amansinghbais amansinghbais moved this to 🏗 In progress in Digital Experience Platform Jan 29, 2024
amansinghbais added a commit to amansinghbais/facilities that referenced this issue Jan 29, 2024
@amansinghbais
Improved: toast message for creating facility with duplicate facility…
227a26f 
…Id (hotwax#185)
@amansinghbais amansinghbais mentioned this issue Jan 29, 2024
Closed
1 task
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Jan 29, 2024
amansinghbais added a commit to amansinghbais/facilities that referenced this issue Jan 29, 2024
@amansinghbais
Improved: condition for checking if facility exists (hotwax#185)
b2fccb4
amansinghbais added a commit to amansinghbais/facilities that referenced this issue Jan 29, 2024
@amansinghbais
Improved: code for better api call with payload (hotwax#185)
0ce13b2
amansinghbais added a commit to amansinghbais/facilities that referenced this issue Feb 19, 2024
@amansinghbais
Improved: returning boolean response from method to check if faiclity…
fc1373d 
… already exists (hotwax#185)
amansinghbais added a commit to amansinghbais/facilities that referenced this issue Feb 19, 2024
@amansinghbais
Improved: logic for returning boolean for whether facility already ex…
da44982 
…ists (hotwax#185)
@amansinghbais
Copy link
Contributor

Based on discussion, we will be showing error message from server dynamically in case of facility creation failure due to duplicate facilityId.

@amansinghbais amansinghbais moved this from 👀 In review to 📅 Planned in Digital Experience Platform Jul 16, 2024
@amansinghbais amansinghbais moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Jul 16, 2024
amansinghbais added a commit to amansinghbais/facilities that referenced this issue Jul 16, 2024
@amansinghbais
Improved: error handling while parking creation to show error message…
2059048 
… from server (hotwax#185)
@amansinghbais amansinghbais mentioned this issue Jul 16, 2024
Merged
1 task
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Jul 16, 2024
ymaheshwari1 added a commit that referenced this issue Jul 18, 2024
@ymaheshwari1
Merge pull request #287 from amansinghbais/#185
b6574bf 
Improved: error handling while parking creation to show error message from server (#185)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Jul 18, 2024
@Adameddy26 Adameddy26 self-assigned this Aug 20, 2024
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 🛠 In QA in Digital Experience Platform Aug 20, 2024
@Adameddy26
Copy link

Verified and working fine in release v1.9.0. Hence, closing it.

@github-project-automation github-project-automation bot moved this from 🛠 In QA to ✅ Done in Digital Experience Platform Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
enhancement New feature or request release-v1.9.0
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
3 participants
@ravilodhi @amansinghbais @Adameddy26