Improved: toast message for creating facility with duplicate facility id (#185) #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
requested changes
Jan 29, 2024
| @@ -130,6 +131,11 @@ export default defineComponent({ | |||
| this.formData.facilityId = generateInternalId(this.formData.facilityName) | |||
| } | |||
|
|
|||
| if(this.formData.facilityId && this.isFacilityAlreadyExists()) { | |||
There was a problem hiding this comment.
I think this check is not required, as flow of code will not come here without having a facilityId.
| @@ -170,6 +176,9 @@ export default defineComponent({ | |||
| markFacilityIdTouched() { | |||
| (this as any).$refs.facilityId.$el.classList.add('ion-touched'); | |||
| }, | |||
| isFacilityAlreadyExists() { | |||
| return this.virtualFacilities.some((facility: any) => facility.facilityId === this.formData.facilityId) || this.archivedFacilities.some((facility: any) => facility.facilityId === this.formData.facilityId) | |||
There was a problem hiding this comment.
This will only check for facilityId in facilities those are displayed on the UI as we fetch facilities in batches, and will not check across all the facilities available.
ymaheshwari1
requested changes
Feb 19, 2024
| @@ -170,6 +176,29 @@ export default defineComponent({ | |||
| markFacilityIdTouched() { | |||
| (this as any).$refs.facilityId.$el.classList.add('ion-touched'); | |||
| }, | |||
| async isFacilityAlreadyExists() { | |||
There was a problem hiding this comment.
This method should return a boolean instead of returning a number.
ymaheshwari1
requested changes
Feb 19, 2024
| logger.error(err) | ||
| } | ||
|
|
||
| return facilitiesCount > 0 |
There was a problem hiding this comment.
Instead we should define a variable isFacilityExist and toggle its value based on the api response.
|
Based on discussion, we have concluded to show server side error messages in case of api failure due to duplicate facilityId. Hence closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #185
Short Description and Why It's Useful
Improved the create parking workflow to show clear error message while creating parking with duplicate facility ID.
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance