Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Set keyboard type for stock input field(#2cqz21c) #85

Merged
merged 2 commits into from
May 26, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/views/count.vue
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
</div>
<ion-item>
<ion-label position="floating">{{ $t("Stock") }}</ion-label>
<ion-input v-model="product.quantity"></ion-input>
<ion-input inputmode="numeric" v-model="product.quantity"></ion-input>
Copy link
Contributor

@adityasharma7 adityasharma7 May 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could change type to number as well. @dt2patel WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. then we should also set min value as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, Sir, I will fix it.

</ion-item>
<ion-item lines="none">
<ion-note id="stockCount">{{ $t("Enter the count of stock on the shelf.") }}</ion-note>
Expand Down