Implemented: Static UI for the more jobs sections(#2wn5yyv) #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dt2patel
requested changes
Oct 13, 2022
shashwatbangar
changed the title
… display MoreJobs(#2wn5yyv)
dt2patel
approved these changes
Oct 18, 2022
adityasharma7
suggested changes
Oct 18, 2022
|
|
||
| <ion-card> | ||
| <ion-card-header> | ||
| <ion-card-title>{{ $t("More jobs") }}</ion-card-title> |
| @@ -33,6 +33,26 @@ | |||
| </ion-label> | |||
| </ion-item> | |||
| </ion-card> | |||
|
|
|||
| <ion-card> | |||
There was a problem hiding this comment.
I think we should create a separate component and reuse throughout the app
There was a problem hiding this comment.
Yes sir. We do have a separate component called "MoreJobs" but I created it in the PR I've added functionality part.
PR - #250
Do you want me to display static data through a separate component "MoreJobs"?
|
This is done with #274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance