Implemented: Functionality to fetch more jobs on all pages(#2vjxdha) #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier we had MoreJobs component lying in Inventory view, now it is a seperate component that can be used anywhere(#2vjxdha)
…jxdha) Earlier, we had MoreJobs sections in Inventory page, now defined seperately a MoreJobs component with its seperate states, mutations, actions so it can be used anywhere in the app, just need to change enumTypeId for the page we are fetching MoreJobs(#2vjxdha)
…y jobs configs(#2vjxdha)
…right side(#2vjxdha) Currently in process of fixing this bug, jobConfiguration component opens up below instead of right side. Using emitter to emit the job from MoreJobs component to the component it is placed in & when we click on the job in MoreJobs component, it send the job details through emitter so respective component recieves the job details and that component jobConfiguration will open up the configuration in right side. However it doesn't seems to work.
Earlier JobConfiguration component was opening up below the list of MoreJobs & we expect it open on right side of jobs, Now it is working fine
Earlier we were fetch MoreJobs for all the pages with same enumTypeId, now jobs will be fetched according to the page we are on i.e if on Inventory, More Jobs for inventory page will be fetched, also removed unused code, fetched MoreJobs when component gets mounted instead of created & used unique key to display MoreJobs
Now we are fetching MoreJobs acoording to the page we are coming from like Inventory or Product, improved variable namings and removed unused code
…dha) Earlier we had only one state for more jobs and we were storing all moreJobs in it, now we have seperate job states for pending and draft jobs, also if no jobs present, component will be hidden. If no morePending jobs present then we will show draft ones
Now job title will get set using getEnumName getter which takes systemJobEnumId and return corresponding name associate with that enum
…#2vjxdha) Suppose a job is draft & pending, so now we are fetching all moreJobs jobs & if any job is pending and draft, we will show its pending job
… moreJobs getter. Removed same payload being passed from Inventory, PreOrder, Order & Product pages and centralized it in moreJobs action(#2vjxdha)
…ectly returned it(#2vjxdha)
…obName present, it was throwing error(#2vjxdha)
…operty seperately(#2vjxdha)
… payload while fetching pendingJobs(#2vjxdha)
…eId to get temporalExpression, now corrected and passing tempExprId in getter to fetch correct temporalExpression(#2vjxdha)
…ingle job status at a time, also we were setting title data property in job title through, now removed title & directly updating jobTitle through getEnumName getter(#2vjxdha)
…urning off due to pass by reference problem, now working fine(#2vjxdha-n)
…square to n(#2vjxdha-n)
This reverts commit dbb3caf.
…arameters(#2vjxdha-n)
… method(#2vjxdha-n)
adityasharma7
approved these changes
Nov 10, 2022
shashwatbangar
force-pushed
the
#2vjxdha-n
branch
from
0ca54f5 to
74f36a5
Compare
This was referenced Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #257
Short Description and Why It's Useful
Now we have moreJobs section in our pages (Inventory, PreOrder, Order, Product), so if there are more jobs for the specific page, we can view in this section.
Screenshots of Visual Changes before/after (If There Are Any)
Screen.Recording.2022-10-18.at.5.22.10.PM.mov
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance