Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favorite Product Store and Shopify Shop Not Saved When Password Not Set for User #201

Closed
Adameddy26 opened this issue Apr 10, 2024 · 1 comment
Closed

Favorite Product Store and Shopify Shop Not Saved When Password Not Set for User #201

Adameddy26 opened this issue Apr 10, 2024 · 1 comment
Assignees
@Adameddy26
Labels
bug Something isn't working release-v1.9.0

Comments

@Adameddy26
Copy link

Expected behavior

After choosing a favorite product store and Shopify shop, the selections should be saved to the user's account and remain visible during future logins or app usage, regardless of password status.

Steps to reproduce the issue

Log in the users app with admin/super user.
Create a new user with first name and last name. Choose to set up the user manually.
Navigate to the section for selecting favorite product store and Shopify shop.
Choose the favorite product store and Shopify shop.
Observe the toast message confirming successful selection.
Go back and again open the user details page of newly created user to observe the issue.
Now set the login credentials of this user and again try to save the favorite product store and shopify shop.(This time it will get saved)

Environment details

App version : v1.8.0
App environment : UAT

Additional information

https://jam.dev/c/d8f63f88-8356-4856-b75f-1257682cc67c
@Adameddy26 Adameddy26 added the bug Something isn't working label Apr 10, 2024
@ymaheshwari1 ymaheshwari1 moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Apr 10, 2024
@R-Sourabh R-Sourabh moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Apr 10, 2024
R-Sourabh added a commit to R-Sourabh/user-management that referenced this issue Apr 10, 2024
@R-Sourabh
Improved: productStore is disabled for users without credentials(hotw…
b917544 
…ax#201)
@R-Sourabh R-Sourabh mentioned this issue Apr 10, 2024
Merged
1 task
@R-Sourabh R-Sourabh moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Apr 10, 2024
R-Sourabh added a commit to R-Sourabh/user-management that referenced this issue Apr 12, 2024
@R-Sourabh
Improved: add check for all the falsy values instead of just null(hot…
71983fb 
…wax#201)
R-Sourabh added a commit to R-Sourabh/user-management that referenced this issue Apr 12, 2024
@R-Sourabh
Improved: added check for shopify shop selection(hotwax#201)
c5c1725
ymaheshwari1 added a commit that referenced this issue Apr 12, 2024
@ymaheshwari1
Merge pull request #202 from R-Sourabh/#201-fav-store
8b41b38 
Improved: in fav productStore and shopifyShop, added check for valid userLoginId(#201)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Apr 12, 2024
@Adameddy26 Adameddy26 assigned Adameddy26 and unassigned R-Sourabh Apr 22, 2024
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 🛠 In QA in Digital Experience Platform Apr 22, 2024
@Adameddy26 Adameddy26 moved this from 🛠 In QA to ✅ Done in Digital Experience Platform Apr 22, 2024
@Adameddy26
Copy link
Author

Issue verified and working fine in release v1.9.0. Hence, closing this ticket.
https://jam.dev/c/356511a2-508f-4ce7-a02c-b8249d084e98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
bug Something isn't working release-v1.9.0
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@R-Sourabh @Adameddy26