Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: in fav productStore and shopifyShop, added check for valid userLoginId(#201) #202

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

R-Sourabh
Copy link
Contributor

Related Issues

#201

Short Description and Why It's Useful

  • Disabled the selection of the Favorite ProductStore on UI when user is not fully authentiacted.

Contribution and Currently Important Rules Acceptance

Copy link
Contributor

@ymaheshwari1 ymaheshwari1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the same check for shopify shop selection.

Also the PR title needs to be updated, as you have just added a check for userLoginId.

src/views/UserDetails.vue Outdated Show resolved Hide resolved
@R-Sourabh R-Sourabh changed the title Improved: fav productStore is disabled for users without credentials(#201) Improved: in fav productStore and shopifyShop, added check for valid userLoginId(#201) Apr 12, 2024
@ymaheshwari1 ymaheshwari1 merged commit 8b41b38 into hotwax:main Apr 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants