Fix frame not advancing when using Turbo.visit
#940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you have a frame with `data-trubo-action` attribute and use
`Turbo.visit({frame: "frame-id"})` to navigate the frame the action is
ignored and the url does not change.
This appears to happen as the `visit` method of the frame does not set
the `action` on the `FrameController` as it does in the
`proposeVisitIfNavigatedWithAction`.
To fix this I've set the `action` property on the frame in the visit
method.
pythonandchips
force-pushed
the
bug/fix-visit-navigation-with-action
branch
from
276245d
to
6915c54
Compare
|
Thanks! This was already addressed in #1135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have a frame with
data-trubo-actionattribute and useTurbo.visit({frame: "frame-id"})to navigate the frame the action is ignored and the url does not change. The url will change if a link was click prior to theTurbo.visit. Below is a gif demonstrating the issue.(the example code can been seen in https://github.com/fac/turbo-frame-visit-bug-reproduction)
This appears to happen as the
visitmethod of the frame does not set theactionon theFrameControlleras it does in theproposeVisitIfNavigatedWithAction.To fix this I've set the
actionproperty on the frame in the visit method.I've not had much luck writing a test for this so any help or pointers in writing a test would be much appreciated.