Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frame not advancing when using Turbo.visit #940

Closed

Commits on Jul 6, 2023

  1. Fix frame not advancing when using Turbo.visit

    When you have a frame with `data-trubo-action` attribute and use
    `Turbo.visit({frame: "frame-id"})` to navigate the frame the action is
    ignored and the url does not change.
    
    This appears to happen as the `visit` method of the frame does not set
    the `action` on the `FrameController` as it does in the
    `proposeVisitIfNavigatedWithAction`.
    
    To fix this I've set the `action` property on the frame in the visit
    method.
    pythonandchips committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    6915c54 View commit details
    Browse the repository at this point in the history