-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
High cadence scans #316
Merged
Merged
High cadence scans #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IX a bug in turnaround acceleration.
tskisner
approved these changes
Jan 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of simulating the scan "shape" once and then interpolating to timestamps. That cleanly resolves the issue of sample rates that are too low to reconstruct the turnarounds in simple simulations.
keskitalo
added a commit
that referenced
this pull request
Feb 14, 2020
* Rewrite CES scanning simulation to support sinc-modulated scanning. FIX a bug in turnaround acceleration. * Update data commit hash * add command line options to enable sinc modulation
keskitalo
added a commit
that referenced
this pull request
Mar 6, 2020
* Rewrite CES scanning simulation to support sinc-modulated scanning. FIX a bug in turnaround acceleration. * Update data commit hash * add command line options to enable sinc modulation
keskitalo
added a commit
that referenced
this pull request
Mar 20, 2020
* Rewrite CES scanning simulation to support sinc-modulated scanning. FIX a bug in turnaround acceleration. * Update data commit hash * add command line options to enable sinc modulation
keskitalo
added a commit
that referenced
this pull request
Mar 23, 2020
* Rewrite CES scanning simulation to support sinc-modulated scanning. FIX a bug in turnaround acceleration. * Update data commit hash * add command line options to enable sinc modulation
keskitalo
added a commit
that referenced
this pull request
Apr 8, 2020
* Rewrite CES scanning simulation to support sinc-modulated scanning. FIX a bug in turnaround acceleration. * Update data commit hash * add command line options to enable sinc modulation
keskitalo
added a commit
that referenced
this pull request
May 6, 2020
* refactor ground filter * remove debug statement * refactor groundfilter again * fix bugs * streamline ground filtering * use dot product for speed * Add barriers to reporting * Add tutorials to main repo. Add pointer to these in documentation. * High cadence scans (#316) * Rewrite CES scanning simulation to support sinc-modulated scanning. FIX a bug in turnaround acceleration. * Update data commit hash * add command line options to enable sinc modulation * Add option to systematically rotate the boresight in the schedule * ran black on the entire source tree * Allow user to adjust nside_submap * fix simple pipeline * write a compiled kernel for building the template covariance * More compiled kernels for ground filtering * support scans across zero azimuth * remove autoformatting from unintended files * more unintended formatting * and more * and more * and more * and more * remove merge conflict markers * speed up writing the noise estimates * Replace direct matrix inversion with SVD decomposition in polynomial filtering * Remove unecessary reporting * cannot (and should not) attempt to filter TOD that is completely flagged * Handle situations where there are more polynomial templates than unflagged samples * Symmetrize the template matrix to reduce the problem size * Enable range checking for good * make the atmospheric simulation much more fault tolerant * format source * bug fix to fault checking * skip the near and intermediate fields in simulation, they barely contribute * Get the scan range from the high resolution data so sampling frequency does not matter * more tweaks to ensure sampling rate does not affect atmospheric sim * enable OpNoiseEstim * Add option to simulate the large scale atmosphere using different element size * Apply flags in the coarse ATM simulation as well * Remove obsolete comments * install pysm from pypi * regularize covariance matrix * update serial atm code to match MPI * Atmosphere range checks are enabled by default but can be disabled with a preprocessor variable NO_ATM_CHECKS * Add OpenMP guards * more OpenMP guards Co-authored-by: Theodore Kisner <tskisner.public@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new ground constant elevation scan (CES) mode. With
--scan-sinc-modulate
, the user can instructTODGround
object to simulate CES:s that modulate the scan rate proportional to1/sin(Azimuth)
. This modulation leads to uniform integration depth even when sweeping across wide ranges in Declination. The downside is that the modulation requires increasing the scan rate as the telescope scans towards North or South. It is typically necessary to exclude azimuths within 20-30 degrees of the North or South directions.This PR also fixes a bug in the turnaround simulation that sped up the telescope acceleration and lead to unrealistically short turnaround times.