Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulation tweaks #341

Merged
merged 46 commits into from
May 6, 2020
Merged

Simulation tweaks #341

merged 46 commits into from
May 6, 2020

Conversation

keskitalo
Copy link
Member

This PR contains the latest modifications for SO and CMB-S4 simulations.

keskitalo and others added 30 commits April 8, 2020 12:51
@keskitalo
refactor ground filter
b62f9a9
@keskitalo
remove debug statement
4e331b0
@keskitalo
refactor groundfilter again
b7c8302
@keskitalo
fix bugs
5fdf9ae
@keskitalo
streamline ground filtering
ed404d6
@keskitalo
use dot product for speed
3589290
@keskitalo
Add barriers to reporting
ef46b20
@keskitalo
Add option to systematically rotate the boresight in the schedule
511f6df
@keskitalo
ran black on the entire source tree
537475c
@keskitalo
High cadence scans (#316)
65fb59e 
* Rewrite CES scanning simulation to support sinc-modulated scanning. FIX a bug in turnaround acceleration.

* Update data commit hash

* add command line options to enable sinc modulation
@tskisner @keskitalo
Add tutorials to main repo. Add pointer to these in documentation.
23af2e3
@keskitalo
Allow user to adjust nside_submap
f707ba0
@keskitalo
fix simple pipeline
72d915c
@keskitalo
write a compiled kernel for building the template covariance
4de6f04
@keskitalo
More compiled kernels for ground filtering
18cc9fb
@keskitalo
support scans across zero azimuth
e4e5be2
@keskitalo
remove autoformatting from unintended files
88eadb0
@keskitalo
more unintended formatting
fc7c725
@keskitalo
and more
8546083
@keskitalo
and more
c511150
@keskitalo
and more
6c0e3c1
@keskitalo
and more
78461d6
@keskitalo
remove merge conflict markers
f44bffc
@keskitalo
speed up writing the noise estimates
bdc70d5
@keskitalo
Replace direct matrix inversion with SVD decomposition in polynomial …
cd8d169 
…filtering
@keskitalo
Remove unecessary reporting
9214651
@keskitalo
cannot (and should not) attempt to filter TOD that is completely flagged
a52c389
@keskitalo
Handle situations where there are more polynomial templates than unfl…
b0454e5 
…agged samples
@keskitalo
Symmetrize the template matrix to reduce the problem size
c35acd2
@keskitalo
Enable range checking for good
753b958
@keskitalo keskitalo requested a review from tskisner April 24, 2020 21:37
@keskitalo
Copy link
Member Author

Here it is. Apologies in advance for this massive PR.

tskisner
tskisner requested changes May 5, 2020
View reviewed changes
Copy link
Member

@tskisner tskisner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a couple details about omp stuff.

src/libtoast/src/toast_atm.cpp Outdated Show resolved Hide resolved
src/libtoast/src/toast_tod_filter.cpp Outdated Show resolved Hide resolved
src/libtoast/src/toast_tod_filter.cpp Outdated Show resolved Hide resolved
src/libtoast/src/toast_tod_filter.cpp Show resolved Hide resolved
src/libtoast/src/toast_tod_filter.cpp Outdated Show resolved Hide resolved
src/libtoast_mpi/src/toast_mpi_atm.cpp Outdated Show resolved Hide resolved
@keskitalo
Copy link
Member Author

@tskisner The OpenMP fixes are now in place. Good to merge?

@tskisner
Copy link
Member

tskisner commented May 6, 2020

Yes please :-)

@keskitalo keskitalo merged commit 7bd3ddf into master May 6, 2020
@keskitalo keskitalo deleted the simulation_tweaks branch May 6, 2020 21:55
@keskitalo keskitalo mentioned this pull request May 6, 2020
Closed
@tskisner tskisner mentioned this pull request May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tskisner tskisner tskisner requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keskitalo @tskisner