Support passing None for HWP angles to pointing matrix calculation. #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keskitalo
reviewed
May 6, 2020
keskitalo
reviewed
May 6, 2020
| @@ -33,7 +33,7 @@ class OpPointingHpix(Operator): | |||
| the total response is: | |||
|
|
|||
| .. math:: | |||
| d = cal \\left[\\frac{(1+eps)}{2} I + \\frac{(1-eps)}{2} \\left[Q \\cos{4(a+w)} + U \\sin{4(a+w)}\\right]\\right] | |||
| d = cal \\left[\\frac{(1+eps)}{2} I + \\frac{(1-eps)}{2} \\left[Q \\cos{2a+4w} + U \\sin{2a+4w}\\right]\\right] | |||
There was a problem hiding this comment.
@giuspugl Is this definition of the pointing weights consistent with what Davide used for the LB simulations?
keskitalo
reviewed
May 6, 2020
keskitalo
approved these changes
May 6, 2020
|
I added the check for the buffer length, and explicit reset of |
|
Great! |
Rather than always passing an array of zeros if there is no HWP, support passing None value to the underlying C++ code. Fix an error in the docstring. Add a unit test to verify that no HWP and HWP angles of all zero give matching results.
tskisner
force-pushed
the
pointing_interface
branch
from
43c2cf9
to
1ed3503
Compare
|
This has been rebased after #341. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than always passing an array of zeros if there is no HWP,
support passing None value to the underlying C++ code. Fix an
error in the docstring. Add a unit test to verify that no HWP
and HWP angles of all zero give matching results.
We should rebase this after #343 is merged.