few edits on conviqt.py #346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keskitalo
reviewed
May 11, 2020
| beam_file_i00 = beam_file.replace(".fits", "_I000.fits") | ||
| beam_file_0i0 = beam_file.replace(".fits", "_0I00.fits") | ||
| beam_file_00i = beam_file.replace(".fits", "_00I0.fits") | ||
| beam_file_i00= beam_file.replace('.fits', '_I000.fits') |
There was a problem hiding this comment.
Why these changes? black will revert them back immediately and they clutter the review. It would be helpful to format the source before committing.
keskitalo
reviewed
May 11, 2020
| beam0I0 = self.get_beam(beam_file_0i0, det, verbose) | ||
| beam00I = self.get_beam(beam_file_00i, det, verbose) | ||
|
|
||
| beamI00 =self.get_beam(beam_file_i00, det,verbose ) |
There was a problem hiding this comment.
Same comment about formatting.
keskitalo
reviewed
May 11, 2020
| psitot = psipol + 2 * hwpang | ||
|
|
||
| # I-beam convolution | ||
| pnt = self.get_buffer(theta, phi, psi , det, verbose) |
There was a problem hiding this comment.
Instead of get_buffer(theta, phi, psi, ..) try get_buffer(theta, phi, psi - psipol, ...)
There was a problem hiding this comment.
sorry, not psipol but psitot to include the HWP
keskitalo
reviewed
May 11, 2020
| pnt = self.get_buffer(theta, phi, psi , det, verbose) | ||
| convolved_data = self.convolve(sky, beamI00, detector, pnt, det, verbose) | ||
| # Q-beam convolution | ||
| pnt = self.get_buffer(theta, phi, psi, det, verbose) |
keskitalo
reviewed
May 11, 2020
| # Q-beam convolution | ||
| pnt = self.get_buffer(theta, phi, psi, det, verbose) | ||
| convolved_data += np.cos(2*psitot ) * self.convolve(sky, beam0I0, detector, pnt, det, verbose) | ||
| # U-beam convolution | ||
| pnt = self.get_buffer(theta, phi, psi, det, verbose) |
keskitalo
reviewed
May 11, 2020
| return np.hstack (all_hwpang ) | ||
|
|
||
|
|
||
| def _get_psipol(self, data, det): |
There was a problem hiding this comment.
This implementation will fail if the detector in question is not available in all observations. Please see how get_pointing avoids this issue.
|
This PR is superseded by #347 |
Merged
|
Closing this PR in favor of #347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a new PR to allow editing suggestions