Giuspugl/beamconv #347
Merged
Giuspugl/beamconv #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
With the last commit 1c8ef3b the user can set as an input argument whether to calibrate or not the TOD after the beam has been convolved , not sure this is still consistent with the documentation in toast/src/toast/todmap/conviqt.py Line 51 in 1c8ef3b |
- Avoiding loops over all observations in the convolution method - OpSimWeightedConviqt now inherits from OpSimConviqt - Solved inconsistency in get_psipol - More consistent reference frame definitions, more code reuse - Making apply_weighted_conviqt and OpSimWeightedConvict importable - Do not attempt to remove HWP angle from detector orientation - Adding conviqt-calibrate parser argument
tskisner
force-pushed
the
giuspugl/beamconv
branch
from
1c8ef3b
to
f5f14eb
Compare
tskisner
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #346