Remove dependency on MPI compilers #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskisner
force-pushed
the
pympi
branch
2 times, most recently
from
54930e1
to
b4df739
Compare
|
Ok, I think this branch is ready for more extensive tests on actual simulation pipelines. Running small local tests seem to indicate consistent results and timing compared to the current master branch. |
- Require only mpi4py (all MPI operations done in python). This allows us to build our compiled extensions with any compiler rather than requiring consistency with the compilers used to build mpi4py. - Port the high-level C++ atmosphere simulation code to python and use compiled code only on a single process. Change the on-disk format of cached atmosphere realizations to use hdf5. - Update build system to not look for MPI compilers. - Add a new log level, "VERBOSE" which is even lower than "DEBUG". The intention for this is to contain messages that might come from every single process. - The MPIShared and MPILock classes are found in the upstream pshmem package. Bundle a tagged release of that package for now until it is widely available on PyPI / conda-forge. - Clean up the generation of version.cpp so that it only happens if the version actually changes.
…nto place at the end.
function is actually called. TOAST does not use numba since it conflicts with our existing explicit parallelism. The set_numba_threading() function is designed to be used before calling external packages that use numba, in order to ensure consistency between toast and numba.
… that the kolmo_x spectrum was not being reduced across processes.
|
Ok @keskitalo, this branch now agrees with master on the small test case you shared with me offline. If you could reconfirm that consistency it would be great, and then hopefully we can merge this. |
|
The branch is now fully compatible with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a work in progress. By reorganizing the atmosphere simulation code, we can remove our need for MPI compilers (we just need mpi4py). This means that the internal toast compiled code can be built with any serial compiler. There is no need for consistency between the compilers used to build toast and the compilers used to install mpi4py. This greatly simplifies toast installation and will enable us to distribute binary pip packages.