Begin work to integrate cibuildwheel tests. #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add scripts to be run inside a cibuildwheel docker image on both linux and macos which installs static versions of OpenBLAS (linux only), fftw, and suitesparse. Link our internal _libtoast extension to these static packages, which ensures consistency regardless of other shared libraries loaded by other packages. - Add a github workflow which tests pip wheel building daily, and preserves the wheels as artifacts which can be downloaded and tested as needed. This also runs the unit tests on the installed wheel packages (linux and macos, python 3.6-3.8). - Add a deployment workflow executed on git tags which uploads to pypi. this will likely need some testing during 2.3.7 tag preparation. - Cleanup package definitions in setup.py, version generation, and add a MANIFEST.in file to ensure that extra package files are bundled.
|
Ok, I've squashed all my debugging commits and I think this is ready to go. The pip wheel tests will run daily and generate wheels that can be downloaded manually for testing as artifacts. Whenever there is a tag, the wheels will be uploaded to PyPI. I verified that I could download the generated wheels and install them manually in a virtualenv. @zonca, no pressure to review this if you are busy, but obviously any comments are welcome. It feels good to have all this packaging happening as part of our CI process :-) |
zonca
reviewed
May 29, 2020
|
Appoved by @keskitalo in offline conversation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress. Add building of Linux and MacOS wheels to test runners. These will have MPI support disabled until #350 is merged.