add support for --review-pr #1142
Conversation
| msg = diff | ||
| else: | ||
| msg = "\n(no related easyconfigs found for %s)\n" % os.path.basename(ec['spec']) | ||
| print(msg) |
There was a problem hiding this comment.
generate all the text, print it all once
There was a problem hiding this comment.
and print it all at once in main
|
@boegel didn't check any of the tyests, have to rereview the multidiff (makes my head hurt 😄 ) |
|
I'll need to reopen this to target |
Conflicts: easybuild/framework/easyconfig/tools.py easybuild/tools/github.py
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
…ment fix extracting of comments from an easyconfig file that includes 'tail' comments
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
PR targeting |
wrapper PR for @nudded's #1005
It contains a bunch of cleanups on top of @nudded's work, together with code style cleanup.
@stdweird, @wpoely86: please review/test