Thr 20 create UI elements #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 19, 2023
marode-cap
added
waiting for review
src/pages/H5PEditor.page.vue
Outdated
|
|
||
| async function onValidParams(event: ParamsValidEvent) { | ||
| try { | ||
| const response = await $axios.post<{ |
There was a problem hiding this comment.
why axios? is there no store and then why not using the generated api to call the backend, like other components?
There was a problem hiding this comment.
There is no store because this is not part of the state.
But you are right on not using the generated API, I've updated the code to use it
christian-darsow
approved these changes
Jun 28, 2023
marode-cap
added
WIP
marode-cap
added
waiting for review
SevenWaysDP
approved these changes
Jul 31, 2023
casparneumann-cap
added a commit
that referenced
this pull request
Nov 16, 2023
* Thr 12 h5p editor player (#2540) * Create proxy for h5p editor in dev-environment * basic implementation h5p page * id variable and refactoring * added editor page * change and add routes * sonar issues fixed --------- Co-authored-by: Marvin Rode <marvin.rode@capgemini.com> * Thr 20 create UI elements (#2577) * Integrated H5P Webcomponents into Vue client * add script-src-elem to nginx config * add H5P_IMG_SRC_URLS to nginx config * THR-27: add language param to h5p endpoints (#2734) * add language param to h5p endpoints * generate client server * update h5p imports * THR-6 H5P Editor authorization frontend changes (#2775) * Generate API and include parent information * Vue prop types * add location h5p to csp rules * copy second index.html for h5p location ins csp rules * Update Dockerfile * Update nginx.conf.template * h5p editor: resolve overseen merge conflict termsofuse * delete deprecated code from nuxt removal * h5p editor: csp: remove unsafe inline * fix prettier problem * fix duplicate imports * csp error isolation: set default-src * * csp error isolation: revert and add unsafe-inline for script-src * csp error isolation: set script-src * * csp error isolation: no whitelist used * csp error isolation: set again default-src * * csp error isolation: set script-src * + unsafe inline & eval * csp error isolation: set back to original * csp error isolation: use hash for multiple choice * generate API * csp error isolation: exclude nonce & use unsafe-inline * disable eslint * Update API * resolve review comments * add es / uk languages * try nginx.template h5p fix * revert nginx.conf h5p change * Comment Out H5P CSP * Revert "Comment Out H5P CSP" This reverts commit 1008e2c. * H5pEditor Tests -> Setup Wrapper * initial test for verifying component setup * add test H5pPlayer * restructure H5pEditor Test * Create H5PEditor.page Test * fix routes * Create Test H5pPlayerPage * fix tests h5pPlayerPage --------- Co-authored-by: Majed Mak <132336669+MajedAlaitwniCap@users.noreply.github.com> Co-authored-by: Marvin Rode <marvin.rode@capgemini.com> Co-authored-by: Marvin Rode (Cap) <127723478+marode-cap@users.noreply.github.com> Co-authored-by: Andre Blome <andre-david.blome@capgemini.com> Co-authored-by: Caspar Neumann <caspar.neumann@capgemini.com> Co-authored-by: MajedAlaitwniCap <majed.alaitwni@capgemini.com> Co-authored-by: Cedric Evers <12080057+CeEv@users.noreply.github.com> Co-authored-by: Caspar Neumann <146704428+casparneumann-cap@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
This PR integrates the H5P editor into the vue client
Links to Ticket and related Pull-Requests
hpi-schul-cloud/schulcloud-server#4190
hpi-schul-cloud/schulcloud-client#3211
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging