Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of the tldraw into the new column board #2691

Closed
wants to merge 23 commits into from

Conversation

VikDavydiuk
Copy link
Contributor

Short Description

Links to Ticket and related Pull-Requests

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@VikDavydiuk VikDavydiuk added the WIP someone is working on that label Jul 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

20.0% 20.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Comment on lines +19 to +24

- name: TldrawService
kubernetes.core.k8s:
kubeconfig: ~/.kube/config
namespace: "{{ NAMESPACE }}"
template: tldraw-client-svc.yml.j2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLease add the tldraw-client service only at the tldraw client repo and not in the nuxt repo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delet this file it mess up with the https://github.com/hpi-schul-cloud/tldraw-client/pull/18/files#diff-7e49c294034b2354e445a93c6dbcd7cb582d4790ffc8fa1498bbd4db92610abd and the tldraw-client service shoud be in the tldraw client repo

Comment on lines +43 to +49
const createTldrawClientProxy = () => {
const clientProxy = createProxyMiddleware({
target: "http://localhost:3046",
changeOrigin: true,
});
return clientProxy;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is it configurable if it's not localhost?

@VikDavydiuk VikDavydiuk closed this Dec 4, 2023
@VikDavydiuk VikDavydiuk deleted the BC-4256-Integration-tldraw branch December 4, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP someone is working on that
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants