-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration of the tldraw into the new column board #2691
Conversation
…into BC-4256-Integration-tldraw # Conflicts: # src/components/feature-board/card/CardHost.vue
SonarCloud Quality Gate failed. 0 Bugs 20.0% Coverage The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
|
||
- name: TldrawService | ||
kubernetes.core.k8s: | ||
kubeconfig: ~/.kube/config | ||
namespace: "{{ NAMESPACE }}" | ||
template: tldraw-client-svc.yml.j2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PLease add the tldraw-client service only at the tldraw client repo and not in the nuxt repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please delet this file it mess up with the https://github.com/hpi-schul-cloud/tldraw-client/pull/18/files#diff-7e49c294034b2354e445a93c6dbcd7cb582d4790ffc8fa1498bbd4db92610abd and the tldraw-client service shoud be in the tldraw client repo
const createTldrawClientProxy = () => { | ||
const clientProxy = createProxyMiddleware({ | ||
target: "http://localhost:3046", | ||
changeOrigin: true, | ||
}); | ||
return clientProxy; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is it configurable if it's not localhost?
Short Description
Links to Ticket and related Pull-Requests
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging