BC-4256 integration tldraw #4277
Conversation
# Conflicts: # package-lock.json
# Conflicts: # package-lock.json
…C-4256-Integration-tldraw
.github/workflows/clean.yml
Outdated
| @@ -7,7 +7,7 @@ jobs: | |||
| clean: | |||
| permissions: | |||
| contents: read | |||
| uses: hpi-schul-cloud/dof_app_deploy/.github/workflows/clean_workflow.yml@main | |||
| uses: hpi-schul-cloud/dof_app_deploy/.github/workflows/clean_workflow.yml@BC-4256-Integration-tldraw | |||
| @@ -138,7 +138,7 @@ jobs: | |||
| needs: | |||
| - build_and_push | |||
| - branch_meta | |||
| uses: hpi-schul-cloud/dof_app_deploy/.github/workflows/deploy.yml@main | |||
| uses: hpi-schul-cloud/dof_app_deploy/.github/workflows/deploy.yml@BC-4256-Integration-tldraw | |||
sonar-project.properties
Outdated
| @@ -4,7 +4,7 @@ sonar.sources=. | |||
| sonar.tests=. | |||
| sonar.test.inclusions=**/*.spec.ts | |||
| sonar.exclusions=**/*.js,jest.config.ts,globalSetup.ts,globalTeardown.ts,**/*.app.ts,**/seed-data/*.ts | |||
| sonar.coverage.exclusions=**/board-management.uc.ts,**/*.module.ts,**/*.factory.ts | |||
| sonar.coverage.exclusions=**/modules/tldraw/**/*.ts,**/board-management.uc.ts,**/*.module.ts,**/*.factory.ts | |||
There was a problem hiding this comment.
Why is it exluded from code coverage?
There was a problem hiding this comment.
We will change whole directory, for specific files. As me and Dawid Wasik tried, we could't do tests for every line in those files and as i understand sonar requires 100% coverage
There was a problem hiding this comment.
Yes it's required and not optional and you should not try to slip out of it.
@CeEv @Metauriel cann you say somthing about it?
sonar-project.properties
Outdated
| @@ -4,7 +4,7 @@ sonar.sources=. | |||
| sonar.tests=. | |||
| sonar.test.inclusions=**/*.spec.ts | |||
| sonar.exclusions=**/*.js,jest.config.ts,globalSetup.ts,globalTeardown.ts,**/*.app.ts,**/seed-data/*.ts | |||
| sonar.coverage.exclusions=**/board-management.uc.ts,**/*.module.ts,**/*.factory.ts | |||
| sonar.coverage.exclusions=**/modules/tldraw/gateway/tldraw.gateway.ts,**/modules/tldraw/utils/utils.ts,**/board-management.uc.ts,**/*.module.ts,**/*.factory.ts | |||
There was a problem hiding this comment.
Please don't add not tested code to the nest server
There was a problem hiding this comment.
you can write a mock for the external dependencies these files are dealing with, to make it easier to test them. see the ldap.service.ts for an example.
And thanks for reminding me that the board-management is still excluded here, that has to be removed as well (it has been excluded when sonarcloud was first activated, since its not used in production anyway, but it still needs to go)
|
Kudos, SonarCloud Quality Gate passed!
|
blazejpass
removed
the
WIP
Description
Integration of tldraw client and tldraw server
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/BC-4256
hpi-schul-cloud/nuxt-client#2691
hpi-schul-cloud/dof_app_deploy#586
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.