Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N21-1236 add requirements to disable switch #2780

Merged
merged 7 commits into from
Sep 5, 2023

Conversation

IgorCapCoder
Copy link
Contributor

@IgorCapCoder IgorCapCoder commented Aug 31, 2023

Short Description

the enableLdapSyncDuringMigration switch in the MigrationSection should be disabled when user login migration is not active

Links to Ticket and related Pull-Requests

https://ticketsystem.dbildungscloud.de/browse/N21-1236
hpi-schul-cloud/schulcloud-server#4373

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@IgorCapCoder IgorCapCoder merged commit d5f88f1 into main Sep 5, 2023
39 checks passed
@IgorCapCoder IgorCapCoder deleted the N21-1236-toggle-sync-extension branch September 5, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants