Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N21-1236 toggle ldap sync extension #4373

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

IgorCapCoder
Copy link
Contributor

@IgorCapCoder IgorCapCoder commented Aug 31, 2023

Description

On the school-seetings page in the migration section you can toggle an LDAP-sync extension, where new users and classes still get synchronized, even after migration already started. The responsible school feature is getting removed automatically when migration is closed.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/N21-1236
hpi-schul-cloud/nuxt-client#2780

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Copy link
Contributor

@arnegns arnegns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to test it

@IgorCapCoder IgorCapCoder enabled auto-merge (squash) September 5, 2023 13:32
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@IgorCapCoder IgorCapCoder merged commit 01636d4 into main Sep 5, 2023
42 of 43 checks passed
@IgorCapCoder IgorCapCoder deleted the N21-1236-toggle-sync-extension branch September 5, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants