BC-8348 - Implement Sharing and Copying of Room Boards #5338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EzzatOmar
previously approved these changes
Nov 13, 2024
Metauriel
requested changes
Nov 13, 2024
EzzatOmar
reviewed
Nov 14, 2024
There was a problem hiding this comment.
You might want to merge this code almost as it is.
You have introduced the schoolId to the room and fixed some problems via migrations.
I haven't seen any copy,shared functionality here.
The Ticket BC-8348 would be a followup and also be smaller. :)
uidp
force-pushed
the
BC-8348-copy-share-board
branch
from
df2298e to
8b9feea
Compare
Metauriel
reviewed
Nov 29, 2024
apps/server/src/migrations/mikro-orm/Migration20241004121012.ts
Outdated
Show resolved
Hide resolved
Metauriel
requested changes
Nov 29, 2024
apps/server/src/migrations/mikro-orm/Migration20241004121012.ts
Outdated
Show resolved
Hide resolved
Metauriel
previously requested changes
Nov 29, 2024
apps/server/src/migrations/mikro-orm/Migration20241030126666.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/board/service/internal/board-context.service.spec.ts
Outdated
Show resolved
Hide resolved
MartinSchuhmacher
approved these changes
Dec 4, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have to implement sharing and copying of boards that are associated to rooms. Currently this is only possible for boards that belong to courses. In order to do this we have to extend the ShareTokenModule and BoardModule.
Links to Tickets or other pull requests
BC-8348
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.