BC-8348 - Implement Sharing and Copying of Room Boards

apps/server/src/migrations/mikro-orm/Migration202411131005352.ts

@@ -0,0 +1,67 @@
+import { Migration } from '@mikro-orm/migrations-mongodb';
+
+export class Migration20241113100535 extends Migration {
+	async up(): Promise<void> {
+		const teacherRoleUpdate = await this.getCollection('roles').updateOne(
+			{ name: 'teacher' },
+			{
+				$addToSet: {
+					permissions: {
+						$each: ['ROOM_CREATE'],
+					},
+				},
+			}
+		);
+
+		if (teacherRoleUpdate.modifiedCount > 0) {
+			console.info('Permissions ROOM_CREATE added to role teacher.');
+		}
+
+		const roomEditorRoleUpdate = await this.getCollection('roles').updateOne(
+			{ name: 'roomeditor' },
+			{
+				$addToSet: {
+					permissions: {
+						$each: ['ROOM_DELETE'],
+					},
+				},
+			}
+		);
+
+		if (roomEditorRoleUpdate.modifiedCount > 0) {
+			console.info('Permissions ROOM_DELETE added to role roomeditor.');
+		}
+	}
+
+	async down(): Promise<void> {
+		const teacherRoleUpdate = await this.getCollection('roles').updateOne(
+			{ name: 'teacher' },
+			{
+				$pull: {
+					permissions: {
+						$in: ['ROOM_CREATE'],
+					},
+				},
+			}
+		);
+
+		if (teacherRoleUpdate.modifiedCount > 0) {
+			console.info('Rollback: Permission ROOM_CREATE added to role teacher.');
+		}
+
+		const roomEditorRoleUpdate = await this.getCollection('roles').updateOne(
+			{ name: 'roomeditor' },
+			{
+				$pull: {
+					permissions: {
+						$in: ['ROOM_DELETE'],
+					},
+				},
+			}
+		);
+
+		if (teacherRoleUpdate.modifiedCount > 0) {
+			console.info('Rollback: Permission ROOM_DELETE added to role roomeditor.');
+		}
+	}
+}

apps/server/src/modules/room/api/room.uc.ts

@@ -38,8 +38,8 @@ export class RoomUc {
 
 		const user = await this.authorizationService.getUserWithPermissions(userId);
 		const room = await this.roomService.createRoom({ ...props, schoolId: user.school.id });
-		// NOTE: currently only teacher are allowed to create rooms. Could not find simpler way to check this.
-		this.authorizationService.checkOneOfPermissions(user, [Permission.COURSE_CREATE]);
+		// NOTE: currently only teachers are allowed to create rooms. Could not find simpler way to check this.
+		this.authorizationService.checkOneOfPermissions(user, [Permission.ROOM_CREATE]);
 		await this.roomMemberService
 			.addMembersToRoom(room.id, [{ userId: user.id, roleName: RoleName.ROOM_EDITOR }], user.school.id)
 			.catch(async (err) => {
@@ -88,7 +88,7 @@ export class RoomUc {
 		this.checkFeatureEnabled();
 		const room = await this.roomService.getSingleRoom(roomId);
 
-		await this.checkRoomAuthorization(userId, roomId, Action.write);
+		await this.checkRoomAuthorization(userId, roomId, Action.write, [Permission.ROOM_DELETE]);
 		await this.roomService.deleteRoom(room);
 	}
 
@@ -153,10 +153,15 @@ export class RoomUc {
 		return authorizedRoomIds.map((item) => item.roomId);
 	}
 
-	private async checkRoomAuthorization(userId: EntityId, roomId: EntityId, action: Action): Promise<void> {
+	private async checkRoomAuthorization(
+		userId: EntityId,
+		roomId: EntityId,
+		action: Action,
+		requiredPermissions: Permission[] = []
+	): Promise<void> {
 		const roomMemberAuthorizable = await this.roomMemberService.getRoomMemberAuthorizable(roomId);
 		const user = await this.authorizationService.getUserWithPermissions(userId);
-		this.authorizationService.checkPermission(user, roomMemberAuthorizable, { action, requiredPermissions: [] });
+		this.authorizationService.checkPermission(user, roomMemberAuthorizable, { action, requiredPermissions });
 	}
 
 	private checkFeatureEnabled(): void {

apps/server/src/shared/domain/interface/permission.enum.ts

@@ -100,8 +100,10 @@ export enum Permission {
 	ROLE_CREATE = 'ROLE_CREATE',
 	ROLE_EDIT = 'ROLE_EDIT',
 	ROLE_VIEW = 'ROLE_VIEW',
+	ROOM_CREATE = 'ROOM_CREATE',
 	ROOM_EDIT = 'ROOM_EDIT',
 	ROOM_VIEW = 'ROOM_VIEW',
+	ROOM_DELETE = 'ROOM_DELETE',
 	SCHOOL_CHAT_MANAGE = 'SCHOOL_CHAT_MANAGE',
 	SCHOOL_CREATE = 'SCHOOL_CREATE',
 	SCHOOL_EDIT = 'SCHOOL_EDIT',

apps/server/src/shared/testing/user-role-permissions.ts

@@ -103,6 +103,7 @@ export const teacherPermissions = [
 	Permission.TOPIC_EDIT,
 	Permission.START_MEETING,
 	Permission.CONTEXT_TOOL_ADMIN,
+	Permission.ROOM_CREATE,
 ];
 
 export const adminPermissions = [

backup/setup/migrations.json

@@ -286,5 +286,41 @@
 		"created_at": {
 			"$date": "2024-11-12T16:52:17.292Z"
 		}
+	},
+	{
+		"_id": {
+			"$oid": "67347bb8b1bcb78aecbab90d"
+		},
+		"name": "Migration2024111116041242",
+		"created_at": {
+			"$date": "2024-11-13T10:13:12.402Z"
+		}
+	},
+	{
+		"_id": {
+			"$oid": "67347bb8b1bcb78aecbab90e"
+		},
+		"name": "Migration20241112163538",
+		"created_at": {
+			"$date": "2024-11-13T10:13:12.409Z"
+		}
+	},
+	{
+		"_id": {
+			"$oid": "67347bb8b1bcb78aecbab90f"
+		},
+		"name": "Migration20241113100535",
+		"created_at": {
+			"$date": "2024-11-13T10:13:12.411Z"
+		}
+	},
+	{
+		"_id": {
+			"$oid": "6734805b32785b5d369ed96a"
+		},
+		"name": "Migration202411131005352",
+		"created_at": {
+			"$date": "2024-11-13T10:32:59.991Z"
+		}
 	}
 ]

backup/setup/roles.json

@@ -214,7 +214,7 @@
 		},
 		"name": "teacher",
 		"updatedAt": {
-			"$date": "2024-04-19T10:32:51.070Z"
+			"$date": "2024-11-12T16:35:53.763Z"
 		},
 		"createdAt": {
 			"$date": "2017-01-01T00:06:37.148Z"
@@ -263,7 +263,8 @@
 			"USERGROUP_CREATE",
 			"USERGROUP_EDIT",
 			"USER_CHANGE_OWN_NAME",
-			"USER_CREATE"
+			"USER_CREATE",
+			"ROOM_CREATE"
 		],
 		"__v": 2
 	},
@@ -598,7 +599,8 @@
 		"name": "roomeditor",
 		"permissions": [
 			"ROOM_VIEW",
-			"ROOM_EDIT"
+			"ROOM_EDIT",
+			"ROOM_DELETE"
 		]
 	}
 ]