1.3.0 last-minute regressions? #8966

hrydgard · 2016-09-10T09:15:51Z

Release is planned to be in one week, on Sept 17 or 18.

Any regressions remaining? Otherwise we're ready. ~~#8965~~ has been merged and confirmed working.

…8966 Also update lang.

hrydgard · 2016-09-10T10:26:37Z

We don't do official iOS releases so that's a separate issue. However I did just find something strange that may be related to that issue. Committed de16439 , now keep that issue in #8941 please.

unknownbrackets · 2016-09-10T13:03:14Z

Can we please not release v1.3.0 with crippled logging / debugging capabilities?

Or are you going to make sure to plaster instructions everywhere on how to report bugs properly with graphics logging so we can know when FBOs or other errors are occurring since logs won't include it?

I really don't want a stable release that everyone will be reporting issues with and uploading logs from to have logs that will be broken in ways I'll definitely forget. Unless we feel like there are no more bugs that need to be fixed?

-[Unknown]

hrydgard · 2016-09-10T15:05:58Z

@Fadi5555 no [unknown] was disapproving of my "fix" which isn't a good one. Better one coming up.

hrydgard · 2016-09-10T15:26:40Z

Better log fix merged. Now let's get back to regressions. Only one I know of is FIFA perf regression...

unknownbrackets · 2016-09-10T16:24:33Z

Does anyone have FIFA? What we need is a profile.

One can create a profile using e.g.:

# With ab.sh
./ab.sh HEADLESS=0 ANDROID_NDK_PROFILER=1 NDK_DEBUG=0

# Using ant
ant debug -Dndkbuildopt="HEADLESS=0 ANDROID_NDK_PROFILER=1 NDK_DEBUG=0 APP_ABI=armeabi-v7a -j7"
adb shell am force-stop org.ppsspp.ppsspp
adb install -r bin/PPSSPP-debug.apk

Then run FIFA and go through the slow parts for a while. After that:

adb pull /sdcard/gmon.out
$NDK/toolchains/arm-linux-androideabi-4.9/prebuilt/windows-x86_64/bin/arm-linux-androideabi-gprof obj/local/armeabi-v7a/ppsspp/libppsspp_jni.so -q -p > prof.txt

Most ideal would be a before and after to see why it's different...

(there are of course many other tools available, many SoC vendor specific.)

-[Unknown]

Anuskuss · 2016-09-10T17:53:51Z

@hrydgard Can you give the translators some time before releasing this? Mainly because this is a stable release and there might be some people which will use this for a long time and it would be sad to not have everything translated in it.

Missing things in `en_US.ini`

Tools -> Developer tools -> Texture Replacement
Tools -> Developer tools -> Texture Replacement -> Save new textures
Tools -> Developer tools -> Texture Replacement -> Replace textures
Tools -> Developer tools -> Texture Replacement -> Create/Open textures.ini file for current game
Tools -> Remote disc streaming
Tools -> Remote disc streaming -> Browse Games
Tools -> Remote disc streaming -> Share Games (Server)
System -> Memory Stick inserted
System -> Record Display
System -> Use Lossless Video Coded (FFV1)
System -> Record Audio
Add setting tips on selection #8913 (shouldn't be hardcoded)

hrydgard · 2016-09-10T18:27:55Z

@Anuskuss well, they've got a week... Also, translations could have been submitted any time, we do have a builtbot, etc.

unknownbrackets · 2016-09-10T18:36:33Z

What part of #8913 is hardcoded?

-[Unknown]

sum2012 · 2016-09-10T21:19:22Z

I think that need #8912 need fix

sum2012 · 2016-09-11T05:37:43Z

How about #8846 ? although need rebased

sum2012 · 2016-09-11T12:48:58Z

Need fix #8969 although not regression

LunaMoo · 2016-09-11T13:04:52Z

Another regression #8970

unknownbrackets · 2016-09-11T13:47:37Z

No, #7740 is not a regression and was already an issue in v1.2.x and v1.1.x.

This is open source, so you're free to work on it and try to fix it. I'm sure we'd be happy to accept a good fix - if it looks safe enough and you manage to find a fix soon enough, making it into v1.3.0 is definitely possible.

-[Unknown]

zminhquanz · 2016-09-11T13:59:03Z

what about Multithreading ??

unknownbrackets · 2016-09-11T14:02:52Z

We're also happy to accept pull requests for multithreading improvements that seem sound. But they won't make us wait more months to release v1.3.0.

-[Unknown]

zminhquanz · 2016-09-11T14:05:03Z

and are you interesting about make UMD video like JPCSP ??

unknownbrackets · 2016-09-11T14:14:15Z

I'm going to start deleting feature request replies. That's not what this issue is for, why don't you post on the forum instead?

-[Unknown]

Anuskuss · 2016-09-12T01:43:56Z

@hrydgard
Well, the keys are missing.

@unknownbrackets

settingInfo_->Show(gr->T("RenderingMode NonBuffered Tip", "Faster, but nothing may draw in some games"), e.v);

It outputs this default message and isn't reading from the .ini file, is it?

unknownbrackets · 2016-09-12T01:59:48Z

It is reading from the ini file. Use RenderingMode NonBuffered Tip = Foo. Those are exactly the keys.

-[Unknown]

Anuskuss · 2016-09-12T02:03:37Z

But shouldn't it then output a variable instead of text?

unknownbrackets · 2016-09-12T02:22:57Z

No, if the key is not found in the ini file, it uses the default value. If it is found in the ini file, it uses the ini file's value.

This is used here too, for example:

ppsspp/UI/GameSettingsScreen.cpp

Line 1175 in b06359e

screenManager()->push(

Spanish already has a translation:
https://github.com/hrydgard/ppsspp-lang/blob/da3f290a4626d4f1596ca35201ada164e0caa7ae/es_ES.ini#L394

-[Unknown]

Anuskuss · 2016-09-12T03:03:22Z

Well okay, my bad. I didn't assume there should be a default value but rather it would read from en_US.ini if a translation can't be found.

So will en_US.ini get updated or are the translators suppost to dig through the code, find the specific key and then translate it?

hrydgard · 2016-09-12T09:20:05Z

The latter. I know our translation system isn't great... Been meaning to find something else, preferably something with online editing etc.

sum2012 · 2016-09-12T11:38:32Z

While I do translate zh_CN and zh_TW , I also update en_us.ini

hrydgard · 2016-09-12T11:55:01Z

Thanks @sum2012

sum2012 · 2016-09-12T13:26:03Z

@Anuskuss
I just translate finish chinese,I also update en_us.ini
Please check to translate your lang.
hrydgard/ppsspp-lang@b5257e0
hrydgard/ppsspp-lang@cdf4a8d

gannon345 · 2016-09-12T23:38:15Z

There seems to have been a regression in the UI as of latest builds, at least for Android. Tapping "settings" in the main menu doesn't actually tap settings, it taps the game furthest to the right in the games list. Seems the touch is all shifted to the left, as none of the menu items on the right are working.

Selecting items with a controller still works normally, and the settings and all games in the list are selectable that way. It's only the touch UI that's behaving abnormally.

unknownbrackets · 2016-09-14T04:18:44Z

What's the most recent git build (from the downloads page) that works properly, and the first one that doesn't work properly? If you know that 1.2.2 works and the latest git build doesn't, you can try half way in between. If it works half way, try half way newer, otherwise try halfway older.

Going by halves you can find the cause in 10 or probably less checks. It may also help to say what device you're using, since I wasn't seeing this problem.

-[Unknown]

sum2012 · 2016-09-14T11:40:07Z

My friend have samsung s7
Play God eater 2 1.0 pop up with black screen with "WARNING:Battery save mode is on"
then the game cannot run.Can disable the code for 1.3 ?

hrydgard · 2016-09-14T13:05:32Z

That's just a warning, it has nothing to do with the game not working.

That's the danger of showing warnings, people will associate them with all kinds of failures that happen simultaneously...

sum2012 · 2016-09-14T13:20:03Z

@hrydgard ok,I will try to explain to him

hrydgard · 2016-09-14T13:24:00Z

But yeah, this is probably a bug of some sort, but unlikely related to the battery.

hrydgard · 2016-09-14T20:00:48Z

Please stop nagging, and especially in this thread. I have no more ideas of what the cause might be and I have no way to reproduce the error or investigate currently, so there's not much more I can do.

If you could figure out how to run the app through Xcode Profiler, that could help. Also make really sure that the builds you are using are "release" builds and not "debug" builds.

gannon345 · 2016-09-14T23:23:14Z

Not sure. I was previously on build 678, but after installing the new
builds, the regression even exists with that one after uninstalling and
reinstalling the older version.

On Tue, Sep 13, 2016 at 10:18 PM, Unknown W. Brackets <
notifications@github.com> wrote:

What's the most recent git build (from the downloads page) that works
properly, and the first one that doesn't work properly? If you know that
1.2.2 works and the latest git build doesn't, you can try half way in
between. If it works half way, try half way newer, otherwise try halfway
older.

Going by halves you can find the cause in 10 or probably less checks. It
may also help to say what device you're using, since I wasn't seeing this
problem.

-[Unknown]

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#8966 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHxjlJtQnof3wE8LS7XmMM5c50dXnb-Vks5qp3WxgaJpZM4J5rXG
.

unknownbrackets · 2016-09-15T04:05:44Z

Hmm, try removing the PSP/SYSTEM/ppsspp.ini file from your device - maybe it has to do with some configuration? I'm not sure what it could be...

-[Unknown]

gannon345 · 2016-09-15T04:55:43Z

I'll check. Will I lose any game saves in doing that?

On Wed, Sep 14, 2016 at 10:05 PM, Unknown W. Brackets <
notifications@github.com> wrote:

Hmm, try removing the PSP/SYSTEM/ppsspp.ini file from your device - maybe
it has to do with some configuration? I'm not sure what it could be...

-[Unknown]

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#8966 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHxjlDHtTnK_ybN2gc97f7uu9ibNK6n8ks5qqMQkgaJpZM4J5rXG
.

gannon345 · 2016-09-15T05:08:26Z

Tested it, no change. I even went as far as to back up the entire system
folder, remove the entire folder, then uninstall PPSSPP and reinstall the
older version (tried build 658, known working on my Shield K1 previously).
Same issue. Does PPSSPP save data anywhere besides the PSP folder under
internal storage main path?

On Wed, Sep 14, 2016 at 10:55 PM, Jeff G gannon345@gmail.com wrote:

I'll check. Will I lose any game saves in doing that?

On Wed, Sep 14, 2016 at 10:05 PM, Unknown W. Brackets <
notifications@github.com> wrote:

Hmm, try removing the PSP/SYSTEM/ppsspp.ini file from your device - maybe
it has to do with some configuration? I'm not sure what it could be...

-[Unknown]

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#8966 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHxjlDHtTnK_ybN2gc97f7uu9ibNK6n8ks5qqMQkgaJpZM4J5rXG
.

gannon345 · 2016-09-15T05:15:30Z

Shit, I figured it out and it's all my fault. /facepalm

Apparently, PPSSPP is not playing nice with screen/DPI scaling with the
Nvidia app optimizer. It was all screwy because I had PPSSPP running in
720p (1280x800) as native, instead of the native res of 1920x1200. Odd that
it previously worked, but got screwy after updating. But either way,
consider this an odd one-off case, but probably not an actual issue.

Latest build is running fine now, no menu quirks.

sum2012 · 2016-09-15T09:49:43Z

@hrydgard Can you help to update UI of font atlas ?

Cannot see font "些" in
https://github.com/hrydgard/ppsspp-lang/blob/master/zh_TW.ini#L390

hrydgard · 2016-09-17T10:39:35Z

@sum2012 Font atlas updated :)

sum2012 · 2016-09-17T11:23:00Z

@hrydgard Thanks,font fixed

hrydgard · 2016-09-17T13:28:40Z

Time's up.

hrydgard added this to the v1.3.0 milestone Sep 10, 2016

hrydgard changed the title ~~1.3.0 last-minute regression fixes~~ 1.3.0 last-minute regressions? Sep 10, 2016

hrydgard added a commit that referenced this issue Sep 10, 2016

Initial 1.3.0 release notes, thanks Unknown for collecting them. See #…

508e872

…8966 Also update lang.

hrydgard closed this as completed Sep 17, 2016

1.3.0 last-minute regressions? #8966

1.3.0 last-minute regressions? #8966

Comments

hrydgard commented Sep 10, 2016 • edited Loading

hrydgard commented Sep 10, 2016 • edited Loading

unknownbrackets commented Sep 10, 2016

hrydgard commented Sep 10, 2016 • edited Loading

hrydgard commented Sep 10, 2016

unknownbrackets commented Sep 10, 2016 • edited Loading

Anuskuss commented Sep 10, 2016

Missing things in en_US.ini

hrydgard commented Sep 10, 2016

unknownbrackets commented Sep 10, 2016

sum2012 commented Sep 10, 2016

sum2012 commented Sep 11, 2016

sum2012 commented Sep 11, 2016

LunaMoo commented Sep 11, 2016

unknownbrackets commented Sep 11, 2016

zminhquanz commented Sep 11, 2016 • edited Loading

unknownbrackets commented Sep 11, 2016

zminhquanz commented Sep 11, 2016

unknownbrackets commented Sep 11, 2016

Anuskuss commented Sep 12, 2016

unknownbrackets commented Sep 12, 2016 • edited Loading

Anuskuss commented Sep 12, 2016

unknownbrackets commented Sep 12, 2016 • edited Loading

Anuskuss commented Sep 12, 2016

hrydgard commented Sep 12, 2016

sum2012 commented Sep 12, 2016

hrydgard commented Sep 12, 2016

sum2012 commented Sep 12, 2016

gannon345 commented Sep 12, 2016

unknownbrackets commented Sep 14, 2016

sum2012 commented Sep 14, 2016

hrydgard commented Sep 14, 2016

sum2012 commented Sep 14, 2016

hrydgard commented Sep 14, 2016

hrydgard commented Sep 14, 2016

gannon345 commented Sep 14, 2016

unknownbrackets commented Sep 15, 2016

gannon345 commented Sep 15, 2016

gannon345 commented Sep 15, 2016

gannon345 commented Sep 15, 2016 • edited Loading

sum2012 commented Sep 15, 2016

hrydgard commented Sep 17, 2016

sum2012 commented Sep 17, 2016

hrydgard commented Sep 17, 2016

hrydgard commented Sep 10, 2016 •

edited

Loading

hrydgard commented Sep 10, 2016 •

edited

Loading

hrydgard commented Sep 10, 2016 •

edited

Loading

unknownbrackets commented Sep 10, 2016 •

edited

Loading

Missing things in `en_US.ini`

zminhquanz commented Sep 11, 2016 •

edited

Loading

unknownbrackets commented Sep 12, 2016 •

edited

Loading

unknownbrackets commented Sep 12, 2016 •

edited

Loading

gannon345 commented Sep 15, 2016 •

edited

Loading