Scan the correct sections of modules for code #10501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, fix some off-by-one issues with end addresses.
In this case, we often scan some garbage, but let's reduce it at least.
hrydgard
reviewed
Jan 3, 2018
| MIPSAnalyst::ScanForFunctions(start, end, !gotSymbols); | ||
| } | ||
|
|
||
| // Some games don't have any sections at all. |
There was a problem hiding this comment.
Well, I only know of one so far - Frontier Gate Boost (demo). I'm not certain it's unmodified, though...
-[Unknown]
unknownbrackets
added a commit
to unknownbrackets/ppsspp
that referenced
this pull request
Mar 17, 2018
This fixes the loading speed regression from hrydgard#10501.
This was referenced Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we were either just scanning the text section, or else scanning too much. Some games use a separate "init" section or even in some cases multiple sections with code. This meant we weren't even scanning those.
This more accurately detects those sections, and tries a bit harder to avoid scanning non-code for functions.
-[Unknown]