ScanForFunctions: Skip invalid code sections. May help #12414. #12418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknownbrackets
approved these changes
Oct 13, 2019
| @@ -1274,6 +1274,11 @@ static Module *__KernelLoadELFFromPtr(const u8 *ptr, size_t elfSize, u32 loadAdd | |||
| std::vector<SectionID> codeSections = reader.GetCodeSections(); | |||
| for (SectionID id : codeSections) { | |||
| u32 start = reader.GetSectionAddr(id); | |||
| if (!Memory::IsValidAddress(start)) { | |||
There was a problem hiding this comment.
Maybe should validate end too, clamping it to valid. I wonder if this is some game hack.
-[Unknown]
There was a problem hiding this comment.
Could very well be, good to have the checks either way though. Yeah, I could have used IsValidRange, I'll switch to that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an immediately obvious way that #10501 could have started crashing when loading things.