GPU: Fix safe size checks when rect offscreen #13941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested win x64 build does not fix the problem for #13346 |
|
If you add the game ID to -[Unknown] |
|
added id UCJS10085 = true in DisableFirstFrameReadback in compat.ini but nothing change. I don't know if this helps anything but if disable LSU from jit the game work fine.
|
|
Great catch! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13327 and #12858. When something had all coordinates negative, we could set safeWidth or safeHeight to negative values. This would then overflow to very positive values (since they are uint16_t) and cause incorrect clearing.
For desktop, this is the cause of #13916 (possibly also mobile.) May also be the cause of #13346 and #13344. If so perhaps we can consider removing the "skip first frame" hack.
-[Unknown]