-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.9.13 fails: Object #<Object> has no method 'parse' #132
Comments
What's your node version? It is no make sense. path object is |
|
Can you debug the code in your node? Found why |
This is what path { resolve: [Function],
normalize: [Function],
join: [Function],
relative: [Function],
sep: '/',
delimiter: ':',
dirname: [Function],
basename: [Function],
extname: [Function],
exists: [Function: deprecated],
existsSync: [Function: deprecated],
_makeLong: [Function] } I will keep digging. |
It appears this was introduced in v0.12. Do you intend to support v0.10? That is the version shipped with Ubuntu 14 (LTS) and 15. If you only support v0.12, you should add an "engines" section to your package.json to make it clear that your package now requires this. |
You may also be able to depend on this polyfill for |
I can confirm that along with a dependence on 'path-parse', this change in formatter.js fixes it for me: var path = require('path');
var events = require('events');
var glob = require('glob');
path.parse = path.parse || require('path-parse'); |
The latest htmlhint (v0.9.13) does not work with node v0.10, which is what Ubuntu 14 LTS comes with. See htmlhint/HTMLHint#132 for more details. Change-Id: Ib148164828317ec56fa32ce3a7b21ae4061333f6
No way to upgrade node version? |
I can upgrade node on my workstation, but that doesn't really help if your package doesn't declare its dependency on node v0.12. People can still clone my project, which depends on htmlhint, try to build it, then get a confusing failure from htmlhint. So until this is fixed, I had to set my project to require v0.9.12 of htmlhint. Either declaring a dependence on node v0.12 or using the path-parse polyfill would help, in my opinion. I would prefer the polyfill, because it means htmlhint running in more places. Either fix would be technically correct, though. |
Thank you very much! |
Wait next release. |
@yaniswang, any idea when the next release will be? |
@yaniswang, will there be a new release any time soon? |
Still no new release? 0.9.12 was missing a feature I needed and 0.9.13 broke support for node v0.10. You've already fixed all the issues I care about. Now I just need 0.9.14 released on npm so I can depend on it and use it in my project. |
This is better than ignoring all camelcase. Introduced by htmlhint/HTMLHint#121 and released in 0.9.13. However, 0.9.13 is incompatible with node v0.10. This was fixed in htmlhint/HTMLHint#132, but there has not been a release since (in 8 months). Therefore we are pinning to today's git version instead of a release. This gets us the camelcase whitelisting feature and doesn't break with node v0.10. Change-Id: I1e3b6c0c96ef24662b46497b1a601bde0dae5704
This is better than ignoring all camelcase. Introduced by htmlhint/HTMLHint#121 and released in 0.9.13. However, 0.9.13 is incompatible with node v0.10. This was fixed in htmlhint/HTMLHint#132, but there has not been a release since (in 8 months). Therefore we are pinning to today's git version instead of a release. This gets us the camelcase whitelisting feature and doesn't break with node v0.10. Change-Id: I1e3b6c0c96ef24662b46497b1a601bde0dae5704
I'm running
./node_modules/.bin/htmlhint demo/index.html
No problem with the same .htmlhintrc in 0.9.12.
.htmlhintrc is
Output is
The text was updated successfully, but these errors were encountered: