Adding support for a white list of attributes that can be lower case. #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When enabling the rule instead of using a boolean, use an array with the attributes (camelCased) that you want to ignore
```json
{
"attr-lowercase": ["viewBox"]
}
```
Fixes htmlhint#28
|
Will this be in 0.9.14? Any idea when that would be released? |
|
It is allready merged into v0.9.13 |
|
Great, thanks! |
shaka-bot
pushed a commit
to shaka-project/shaka-player
that referenced
this pull request
Jan 18, 2017
This is better than ignoring all camelcase. Introduced by htmlhint/HTMLHint#121 and released in 0.9.13. However, 0.9.13 is incompatible with node v0.10. This was fixed in htmlhint/HTMLHint#132, but there has not been a release since (in 8 months). Therefore we are pinning to today's git version instead of a release. This gets us the camelcase whitelisting feature and doesn't break with node v0.10. Change-Id: I1e3b6c0c96ef24662b46497b1a601bde0dae5704
joeyparrish
added a commit
to shaka-project/shaka-player
that referenced
this pull request
Jan 19, 2017
This is better than ignoring all camelcase. Introduced by htmlhint/HTMLHint#121 and released in 0.9.13. However, 0.9.13 is incompatible with node v0.10. This was fixed in htmlhint/HTMLHint#132, but there has not been a release since (in 8 months). Therefore we are pinning to today's git version instead of a release. This gets us the camelcase whitelisting feature and doesn't break with node v0.10. Change-Id: I1e3b6c0c96ef24662b46497b1a601bde0dae5704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling the rule instead of using a boolean, use an array with the attributes (camelCased) that you want to ignore
{ "attr-lowercase": ["viewBox"] }Fixes #28