feat: Add tags checking rule - allows specify rules for any tag and validate that #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
reviewed
May 16, 2020
|
|
||
| var expect = require("expect.js"); | ||
| const expect = require("expect.js"); |
There was a problem hiding this comment.
in this file singlequotes seems to be used
we could format the whole codebase with prettier later, so this wont be an issue for now
Shinigami92
reviewed
May 16, 2020
| parser.addListener('tagstart', function (event) { | ||
| var attrs = event.attrs; | ||
| var col = event.col + event.tagName.length + 1; | ||
| parser.addListener('tagstart', function (event) { |
There was a problem hiding this comment.
we should convert all of this functions to arrow-functions
but we should do this for the whole codebase and use eslint to find all of this occurrences
There was a problem hiding this comment.
That's the plan right after we merge all old PRs :)
Shinigami92
reviewed
May 16, 2020
| @@ -27,7 +27,7 @@ var tagsTypings = { | |||
| } | |||
| }; | |||
|
|
|||
| function assign(target) { | |||
| var assign = function(target) { | |||
Shinigami92
approved these changes
May 16, 2020
thedaviddias
added a commit
that referenced
this pull request
May 18, 2020
…alidate that (#384) * adding tags check rule * fix missing commas * add polifil for old JS engines * add polifil for old JS engines * fix missing commas * fix indexOf * incrace code covarage * incrace code covarage * review fix * fix formating * fixing issues Co-authored-by: a.obitskyi <a.obitskyi@astoundcommerce.com>
github-actions bot
pushed a commit
that referenced
this pull request
May 18, 2020
# [0.13.0](v0.12.2...v0.13.0) (2020-05-18) ### Bug Fixes * add prettier and eslint ([#388](#388)) ([aba3249](aba3249)) * add semantic release test ([#399](#399)) ([616f9cd](616f9cd)) * ignore PULL_REQUEST_TEMPLATE.md ([30b0af2](30b0af2)) * use yml in semantic.yml ([86f6700](86f6700)) ### Features * Add tags checking rule - allows specify rules for any tag and validate that ([#384](#384)) ([475aaca](475aaca)) * added attr-no-unnecessary-whitespace rule ([#385](#385)) ([03bfd4f](03bfd4f)) * new rule: input-requires-label - All inputs require a label ([#159](#159)) ([5bd40fb](5bd40fb)) * new website for htmlhint.com ([#395](#395)) ([5d0d95f](5d0d95f))
Shinigami92
pushed a commit
that referenced
this pull request
May 19, 2020
…alidate that (#384) * adding tags check rule * fix missing commas * add polifil for old JS engines * add polifil for old JS engines * fix missing commas * fix indexOf * incrace code covarage * incrace code covarage * review fix * fix formating * fixing issues Co-authored-by: a.obitskyi <a.obitskyi@astoundcommerce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR done by @SqrTT #184
Short description of what this resolves:
Add tags checking rule