-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add tags checking rule - allows specify rules for any tag and validate that #384
Conversation
|
||
var expect = require("expect.js"); | ||
const expect = require("expect.js"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this file singlequotes seems to be used
we could format the whole codebase with prettier later, so this wont be an issue for now
parser.addListener('tagstart', function (event) { | ||
var attrs = event.attrs; | ||
var col = event.col + event.tagName.length + 1; | ||
parser.addListener('tagstart', function (event) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should convert all of this functions to arrow-functions
but we should do this for the whole codebase and use eslint to find all of this occurrences
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the plan right after we merge all old PRs :)
@@ -27,7 +27,7 @@ var tagsTypings = { | |||
} | |||
}; | |||
|
|||
function assign(target) { | |||
var assign = function(target) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…alidate that (#384) * adding tags check rule * fix missing commas * add polifil for old JS engines * add polifil for old JS engines * fix missing commas * fix indexOf * incrace code covarage * incrace code covarage * review fix * fix formating * fixing issues Co-authored-by: a.obitskyi <a.obitskyi@astoundcommerce.com>
# [0.13.0](v0.12.2...v0.13.0) (2020-05-18) ### Bug Fixes * add prettier and eslint ([#388](#388)) ([aba3249](aba3249)) * add semantic release test ([#399](#399)) ([616f9cd](616f9cd)) * ignore PULL_REQUEST_TEMPLATE.md ([30b0af2](30b0af2)) * use yml in semantic.yml ([86f6700](86f6700)) ### Features * Add tags checking rule - allows specify rules for any tag and validate that ([#384](#384)) ([475aaca](475aaca)) * added attr-no-unnecessary-whitespace rule ([#385](#385)) ([03bfd4f](03bfd4f)) * new rule: input-requires-label - All inputs require a label ([#159](#159)) ([5bd40fb](5bd40fb)) * new website for htmlhint.com ([#395](#395)) ([5d0d95f](5d0d95f))
…alidate that (#384) * adding tags check rule * fix missing commas * add polifil for old JS engines * add polifil for old JS engines * fix missing commas * fix indexOf * incrace code covarage * incrace code covarage * review fix * fix formating * fixing issues Co-authored-by: a.obitskyi <a.obitskyi@astoundcommerce.com>
Initial PR done by @SqrTT #184
Short description of what this resolves:
Add tags checking rule