Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add semantic release test #399

Merged
merged 2 commits into from
May 18, 2020
Merged

Conversation

thedaviddias
Copy link
Member

Short description of what this resolves:

Add release test on master PR

Proposed changes:

  • Add a test release github action
  • Change package.json version to be 0.0.0-semantically-released

@Shinigami92
Copy link
Contributor

This will currently only work on merge into master
We may disable the other workflow and/or use

on:
  pull_request:
    branches:
      - master
      - develop

I see the important part here is the --dry-run

@thedaviddias
Copy link
Member Author

We don't want the test release to work on develop, only on master to have a preview of what will be in the release.

@Shinigami92
Copy link
Contributor

We don't want the test release to work on develop, only on master to have a preview of what will be in the release.

Yes, but it is a dry-run release and not a real release

with this we can check if a merge into master will be fine or not

@thedaviddias thedaviddias merged commit c9926bb into develop May 18, 2020
@thedaviddias thedaviddias deleted the fix/semantic-release-test branch May 18, 2020 16:07
thedaviddias added a commit that referenced this pull request May 18, 2020
github-actions bot pushed a commit that referenced this pull request May 18, 2020
# [0.13.0](v0.12.2...v0.13.0) (2020-05-18)

### Bug Fixes

* add prettier and eslint ([#388](#388)) ([aba3249](aba3249))
* add semantic release test ([#399](#399)) ([616f9cd](616f9cd))
* ignore PULL_REQUEST_TEMPLATE.md ([30b0af2](30b0af2))
* use yml in semantic.yml ([86f6700](86f6700))

### Features

* Add tags checking rule - allows specify rules for any tag and validate that ([#384](#384)) ([475aaca](475aaca))
* added attr-no-unnecessary-whitespace rule ([#385](#385)) ([03bfd4f](03bfd4f))
* new rule: input-requires-label - All inputs require a label ([#159](#159)) ([5bd40fb](5bd40fb))
* new website for htmlhint.com ([#395](#395)) ([5d0d95f](5d0d95f))
Shinigami92 pushed a commit that referenced this pull request May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants