-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix url repo pkg #413
Conversation
package.json
Outdated
@@ -4,7 +4,7 @@ | |||
"description": "The Static Code Analysis Tool for your HTML", | |||
"repository": { | |||
"type": "git", | |||
"url": "https://github.com/htmlhint/HTMLHint" | |||
"url": "git+https://github.com//htmlhint/HTMLHint.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need the //
before htmlhint
When I look into other repos like here, there is no double /
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, according to the NPM docs, we could probably use a simpler syntax:
"repository": "npm/npm"
or
"repository": "github:user/repo"
if we want to be more explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how well this works in terms of package.json: "click on link"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before Semantic Release uses that link, I prefer to keep it consistent with all repos.
## [0.13.1-beta.1](v0.13.0...v0.13.1-beta.1) (2020-05-30) ### Bug Fixes * add missing branches to action release ([#425](#425)) ([62c2f3c](62c2f3c)) * add missing plugins for docusaurus ([#402](#402)) ([d9ef347](d9ef347)) * correctly call hint queue drain ([#409](#409)) ([7b63cb2](7b63cb2)) * dupplicate ga ([#407](#407)) ([506f25a](506f25a)) * eslint fix ([820ff8f](820ff8f)) * fix url repo pkg ([#413](#413)) ([b7f5786](b7f5786)) * **attr-no-unnecessary-whitespace:** fix when equals symbol in value ([#405](#405)) ([fe4f3c6](fe4f3c6)) * github token ([18441f6](18441f6))
🎉 This PR is included in version 0.13.1-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [0.13.1](v0.13.0...v0.13.1) (2020-05-31) ### Bug Fixes * add missing branches to action release ([#425](#425)) ([62c2f3c](62c2f3c)) * add missing plugins for docusaurus ([#402](#402)) ([d9ef347](d9ef347)) * correctly call hint queue drain ([#409](#409)) ([7b63cb2](7b63cb2)) * dupplicate ga ([#407](#407)) ([506f25a](506f25a)) * eslint fix ([820ff8f](820ff8f)) * fix url repo pkg ([#413](#413)) ([b7f5786](b7f5786)) * github token ([18441f6](18441f6)) * remove unused dependency esm ([#430](#430)) ([7e8429d](7e8429d)) * **attr-no-unnecessary-whitespace:** fix when equals symbol in value ([#405](#405)) ([fe4f3c6](fe4f3c6))
🎉 This PR is included in version 0.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Short description of what this resolves:
Wrong URI for repo in package JSON