Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix url repo pkg #413

Merged
merged 2 commits into from
May 25, 2020
Merged

fix: fix url repo pkg #413

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a022238
fix: fix url repo pkg
thedaviddias May 23, 2020
f8b3398
fix path
thedaviddias May 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "The Static Code Analysis Tool for your HTML",
"repository": {
"type": "git",
"url": "https://github.com/htmlhint/HTMLHint"
"url": "git+https://github.com//htmlhint/HTMLHint.git"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the // before htmlhint
When I look into other repos like here, there is no double /

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, according to the NPM docs, we could probably use a simpler syntax:

"repository": "npm/npm"

or

"repository": "github:user/repo"

if we want to be more explicit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how well this works in terms of package.json: "click on link"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before Semantic Release uses that link, I prefer to keep it consistent with all repos.

},
"bugs": {
"url": "https://github.com/htmlhint/HTMLHint/issues"
Expand Down
4 changes: 2 additions & 2 deletions website/docusaurus.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const remarkImages = require('remark-images')
const rehypeTruncate = require('rehype-truncate')

const PACKAGE = require('../package')
const GITHUB_URL = `${PACKAGE.repository.url}`
const GITHUB_URL = 'https://github.com/htmlhint/HTMLHint'

module.exports = {
title: 'HTMLHint',
Expand Down Expand Up @@ -89,7 +89,7 @@ module.exports = {
'@docusaurus/preset-classic',
{
docs: {
path: `../docs`,
path: '../docs',
sidebarPath: require.resolve('./sidebars.js'),
showLastUpdateAuthor: true,
showLastUpdateTime: true,
Expand Down