Refactor redirector logic #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures? |
ixti
force-pushed
the
improvement/redirector-logic
branch
2 times, most recently
from
af97906
to
ca44a6f
Compare
Also, I must explain my very own policy about using brackets for method calls.
Generally that will sound like: when it makes sense to make code more obvious.
These are good example when I would not add brackets:
something.makes_good
read_config JSON.parse str
These are example when I will definitely put brackets:
read_config(JSON.parse(str), true) # more than one arg
read_config(params || {}) # not a simple param
ixti
force-pushed
the
improvement/redirector-logic
branch
from
ca44a6f
to
773f2ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #112
Overtakes #178