Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor redirector logic #179

Merged
merged 4 commits into from
Mar 30, 2015
Merged

Refactor redirector logic #179

merged 4 commits into from
Mar 30, 2015

Commits on Mar 30, 2015

  1. Remove useless ssl_class variable in connection 

    Also, I must explain my very own policy about using brackets for method calls.
Generally that will sound like: when it  makes sense to make code more obvious.

These are good example when I would not add brackets:

        something.makes_good
        read_config JSON.parse str

These are example when I will definitely put brackets:

        read_config(JSON.parse(str), true) # more than one arg
        read_config(params || {})          # not a simple param
    @ixti
    ixti committed Mar 30, 2015
    Configuration menu
    Copy the full SHA
    9b4d79e View commit details
    Browse the repository at this point in the history

  2. This should address issue 112

    @hiromipaw @ixti
    hiromipaw authored and ixti committed Mar 30, 2015
    Configuration menu
    Copy the full SHA
    f56444d View commit details
    Browse the repository at this point in the history

  3. Refactoring

    @hiromipaw @ixti
    hiromipaw authored and ixti committed Mar 30, 2015
    Configuration menu
    Copy the full SHA
    7b3e8d8 View commit details
    Browse the repository at this point in the history

  4. Cleanup and refactor redirector

    @ixti
    ixti committed Mar 30, 2015
    Configuration menu
    Copy the full SHA
    773f2ee View commit details
    Browse the repository at this point in the history