Let Host be automatically inferred on redirects #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to break quite a few tests |
|
Oh, that's probably because I forgot that |
When redirecting on "http://localhost:<port>" URLs, the Host will be correctly set to "http://localhost:<port>" on the initial request, but on following the redirect the port is lost, because we're only assigning the host. Therefore when we initialize the follow-up request object we de-assign "Host", and let HTTP::Request set it in the same way as it is set on the initial request.
janko
force-pushed
the
keep-port-in-host-when-redirecting
branch
from
c08d085
to
561fb70
Compare
|
Fixed the implementation and added a test, with verifying that it actually fails without this change. |
|
Thanks for the PR. Can you please add spec for the issue too? |
|
I added it already 😃 |
|
Oh. Indeed. Missed that somehow. Sorry, and thanks again! |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Dec 9, 2017
pkgsrc changes: - sort DEPENDS Upstream changes (from CHANGES.md): ## 3.0.0 (2017-10-01) * Drop support of Ruby `2.0` and Ruby `2.1`. ([@ixti]) * [#410](httprb/http#410) Infer `Host` header upon redirects. ([@janko-m]) * [#409](httprb/http#409) Enables request body streaming on any IO object. ([@janko-m]) * [#413](httprb/http#413), [#414](httprb/http#414) Fix encoding of body chunks. ([@janko-m]) * [#368](httprb/http#368), [#357](httprb/http#357) Fix timeout issue. ([@HoneyryderChuck])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When redirecting on
http://localhost:<port>URLs, the Host will be correctly set tohttp://localhost:<port>on the initial request, but on following the redirect the port is lost, because we're only assigning the host.Therefore when we initialize the follow-up request object we de-assign "Host", and let HTTP::Request set it in the same way as it is set on the initial request.
Since we're stubbing redirects at the moment, I didn't know how to write a test for this.