Return response body chunks in specified encoding #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janko
force-pushed
the
return-response-body-chunks-in-specified-encoding
branch
from
51a87be
to
a6bc27f
Compare
MRI will return content read from the socket in the ASCII-8BIT (binary) encoding, whereas JRuby will return it in the UTF-8 encoding. In whichever encoding the body is retrieved, we want to force its encoding to the one specified (charset response header if present, otherwise binary). This is already the behaviour in Response#to_s, we just extend it to Response#readpartial as well. Fixes httprb#413
janko
force-pushed
the
return-response-body-chunks-in-specified-encoding
branch
from
a6bc27f
to
e3efe86
Compare
|
Thanks! |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Dec 9, 2017
pkgsrc changes: - sort DEPENDS Upstream changes (from CHANGES.md): ## 3.0.0 (2017-10-01) * Drop support of Ruby `2.0` and Ruby `2.1`. ([@ixti]) * [#410](httprb/http#410) Infer `Host` header upon redirects. ([@janko-m]) * [#409](httprb/http#409) Enables request body streaming on any IO object. ([@janko-m]) * [#413](httprb/http#413), [#414](httprb/http#414) Fix encoding of body chunks. ([@janko-m]) * [#368](httprb/http#368), [#357](httprb/http#357) Fix timeout issue. ([@HoneyryderChuck])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MRI will return content read from the socket in the ASCII-8BIT (binary) encoding, whereas JRuby will return it in the UTF-8 encoding. In whichever encoding the body is retrieved, we want to force its encoding to the one specified (charset response header if present, otherwise binary). This is already the behaviour in
Response::Body#to_s, we just extend it toResponse::Body#readpartialas well.Fixes #413.