Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registered routes returning 404 #381

Closed
DrBeak1 opened this issue Apr 5, 2019 · 7 comments
Closed

Registered routes returning 404 #381

DrBeak1 opened this issue Apr 5, 2019 · 7 comments

Comments

@DrBeak1
Copy link

DrBeak1 commented Apr 5, 2019

Having issues potentially related to overlapping routes:
/user/v1/orders/rating/pending
/user/:id/order/active
I thought it may be addressed by #379 but even after modifying the files with these changes still seeing 404s returned for /user/v1/orders/rating/pending.

@Vkt0r
Copy link
Member

Vkt0r commented Apr 7, 2019

@DrBeak1 Thanks for reporting this. I'm afraid this is a duplicate of #376 and after reading more of #378 too!. Your test case was very useful. I'm working on a fix for the issue that would fix the current issues with the routes overlapping.

@Vkt0r
Copy link
Member

Vkt0r commented Apr 7, 2019

@DrBeak1 Can you please point your Podfile or Cartfile to #382 and give it a try with your current repository and let me know if the issue was fixed?

@DrBeak1
Copy link
Author

DrBeak1 commented Apr 8, 2019

@Vkt0r yes this does fix the issue. Thank you very much and sorry for the duplicate.

@DrBeak1 DrBeak1 closed this as completed Apr 8, 2019
@DrBeak1
Copy link
Author

DrBeak1 commented Apr 8, 2019

fixed by #382

@Vkt0r
Copy link
Member

Vkt0r commented Apr 8, 2019

Hey, @DrBeak1 No problem with the duplicate, your case was very helpful to fix the issue, so thanks for it. Glad to know your issue was fixed 😀.

AndrewBennet added a commit to AndrewBennet/ReadingListV1 that referenced this issue Apr 22, 2019
This works around an issue in Swifter 1.4.6 (httpswift/swifter#381)
@AndrewBennet
Copy link

Any chance you could release a new version with this fix? I can't use the current Swift 5 release (1.4.6) because of this issue - I've pointed my Podfile to the latest commit on master instead. Thanks!

@Vkt0r
Copy link
Member

Vkt0r commented Apr 22, 2019

Hey @AndrewBennet yes we would try to release a new version soon, but you can always set your Podfile to the branch stable in the meantime and not to one specific commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants