Fix the HttpRouter problem with overlapping in trail and the middle of routes #382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #378, #381 and #376 and can be resumed in the following steps:
nil
The
findHandler
method was refactored to fix two main issues occurring during the search of a route.testHttpRouterShouldHandleOverlappingRoutesInTrail
added.IndexingIterator<[String]
is mutated after callnext()
.The method was refactored to use a default array with indexes instead of the
IndexingIterator<[String]
to be able to traverse the routes and search correctly and removed the part of the code causing the routes with a dynamic trail were not matched.