[RFC6265bis] Accept nameless cookies. #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch alters the cookie parsing algorithm to treat `Set-Cookie: token` as creating a cookie with an empty name and a value of "token". It also rejects cookies with neither names nor values (e.g. `Set-Cookie:` and `Set-Cookie: =`. Closes #159.
|
@johnwilander: Ping? |
|
Landing this based on the discussion in #159. @johnwilander: If the wording needs more cleanup, I'd appreciate feedback! |
|
The cookie-pair ABNF rule still requires presence of |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 21, 2020
This is based on the recent changes in httpwg/http-extensions#159 and httpwg/http-extensions#1018. Differential Revision: https://phabricator.services.mozilla.com/D60465 --HG-- extra : moz-landing-system : lando
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jan 21, 2020
This is based on the recent changes in httpwg/http-extensions#159 and httpwg/http-extensions#1018. Differential Revision: https://phabricator.services.mozilla.com/D60465
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch alters the cookie parsing algorithm to treat
Set-Cookie: tokenas creating a cookie with an empty name and a valueof "token". It also rejects cookies with neither names nor values (e.g.
Set-Cookie:andSet-Cookie: =.Tests in web-platform-tests/wpt#21093.
Closes #159.